Paths

Table of Contentst

[backup-service] Use shared 'BlobClient' in workers
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:28 AM.

Details

Reviewers

varun
• jon
michal
tomek

Commits

rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers

Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Modified BlobDownloader::start and BlobUploader::start to take BlobClient as an argument instead of creating its own instance.

Depends on D6385

Test Plan

Ran backup service integration and performance tests to confirm it works as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 25 2023, 2:28 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 2:28 AM

bartek added a child revision: D6387: [backup-service] Improve blob client logging.Jan 25 2023, 2:35 AM

Harbormaster completed remote builds in B15626: Diff 21300.Jan 25 2023, 2:41 AM

bartek published this revision for review.Jan 25 2023, 2:46 AM

tomek accepted this revision.Jan 26 2023, 4:25 AM

This revision is now accepted and ready to land.Jan 26 2023, 4:25 AM

Closed by commit rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers (authored by bartek). · Explain WhyJan 31 2023, 2:23 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

blob/

downloader.rs

13 lines

uploader.rs

13 lines

service/

handlers/

8 lines

4 lines

2 lines

8 lines

Diff 21657

View Options

services/backup/src/blob/downloader.rs

View Options

services/backup/src/blob/uploader.rs

View Options

services/backup/src/service/handlers/add_attachments.rs

View Options

services/backup/src/service/handlers/create_backup.rs

View Options

services/backup/src/service/handlers/pull_backup.rs

View Options

services/backup/src/service/handlers/send_log.rs

[backup-service] Use shared 'BlobClient' in workersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21657

services/backup/src/blob/downloader.rs

services/backup/src/blob/uploader.rs

services/backup/src/service/handlers/add_attachments.rs

services/backup/src/service/handlers/create_backup.rs

services/backup/src/service/handlers/pull_backup.rs

services/backup/src/service/handlers/send_log.rs

[backup-service] Use shared 'BlobClient' in workers
ClosedPublic
Actions

Revision Contents
Changeset List