Differential D6384

[backup-service] Add blob client init function
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:17 AM.

Tags

None

Referenced Files

	F1870132: D6384.id.diff
	Sun, May 26, 10:24 PM

	F1870096: D6384.diff
	Sun, May 26, 10:21 PM

	Unknown Object (File)
	Fri, May 24, 6:38 AM

	Unknown Object (File)
	Fri, May 24, 6:20 AM

	Unknown Object (File)
	Fri, May 24, 6:20 AM

	Unknown Object (File)
	Apr 3 2024, 12:10 AM

	Unknown Object (File)
	Apr 3 2024, 12:10 AM

	Unknown Object (File)
	Apr 3 2024, 12:10 AM

View All 58 Files

Subscribers

Details

Reviewers

varun
• jon
michal
tomek

Commits

rCOMMa7374be8b830: [backup-service] Add blob client init function

Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Created a function that initializes a blob client instance. The connection is lazy-initialized so it won't be established until first use.

Depends on D6383

Test Plan

Backup service compiles.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 25 2023, 2:17 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 2:17 AM

bartek added a child revision: D6385: [backup-service] Propagate 'BlobClient' to handlers.Jan 25 2023, 2:23 AM

Harbormaster completed remote builds in B15624: Diff 21298.Jan 25 2023, 2:30 AM

bartek published this revision for review.Jan 25 2023, 2:41 AM

bartek added inline comments.Jan 25 2023, 2:44 AM

services/backup/src/blob/mod.rs
19–20 ↗	(On Diff #21298)	I also consider connecting eagerly to catch connection failure early It would fail with a meaningful error when the backup service is starting - e.g. in cases when you forgot to start Blob service or provided invalid address. But on the other hand, I don't consider it the right way, as the connection isn't actually needed until first request.

tomek accepted this revision.Jan 26 2023, 4:15 AM

tomek added inline comments.

services/backup/src/blob/mod.rs
19–20 ↗	(On Diff #21298)	Both approaches make sense. Also, we can't detect all the issues before the process starts, because the connection can be lost in the middle of the process.

This revision is now accepted and ready to land.Jan 26 2023, 4:15 AM

Closed by commit rCOMMa7374be8b830: [backup-service] Add blob client init function (authored by bartek). · Explain WhyJan 31 2023, 2:23 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa7374be8b830: [backup-service] Add blob client init function.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

blob/

12 lines

Diff 21655

services/backup/src/blob/mod.rs

Loading...