Page MenuHomePhabricator
Differential D6385

[backup-service] Propagate 'BlobClient' to handlers
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 2:04 PM
Unknown Object (File)
Wed, Mar 5, 4:46 PM
Unknown Object (File)
Wed, Mar 5, 4:46 PM
Unknown Object (File)
Wed, Mar 5, 4:45 PM
Unknown Object (File)
Wed, Mar 5, 4:32 PM
Unknown Object (File)
Feb 23 2025, 9:23 PM
Unknown Object (File)
Jan 27 2025, 5:29 AM
Unknown Object (File)
Jan 27 2025, 5:29 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
michal
tomek
Commits
rCOMM64cbee886c03: [backup-service] Propagate 'BlobClient' to handlers
Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Citing https://phab.comm.dev/D6167?id=20696#inline-41664 and Tonic docs - the Channel is encouraged to be cloned and so the BlobClient instance is.
I propagated it to all places where it would be needed, the same way as DynamoDB DatabaseClient. It's not yet used, though.

Depends on D6384

Test Plan

Backup service compiles.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
11 lines
service/
handlers/
9 lines
8 lines
15 lines
6 lines
18 lines

Diff 21656

View Options

services/backup/src/main.rs

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled(); await this.ensureAndroidPushNotifsEnabled();
} }
} }
async ensureAndroidPushNotifsEnabled() { async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase(); const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission(); const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) { if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
return; return;
} }
}
const fcmToken = await firebase.messaging().getToken(); const fcmToken = await firebase.messaging().getToken();
if (fcmToken) { if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken); await this.handleAndroidDeviceToken(fcmToken);
} else { } else {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
} }
} }
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

services/backup/src/service/handlers/add_attachments.rs

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled(); await this.ensureAndroidPushNotifsEnabled();
} }
} }
async ensureAndroidPushNotifsEnabled() { async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase(); const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission(); const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) { if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
return; return;
} }
}
const fcmToken = await firebase.messaging().getToken(); const fcmToken = await firebase.messaging().getToken();
if (fcmToken) { if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken); await this.handleAndroidDeviceToken(fcmToken);
} else { } else {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
} }
} }
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

services/backup/src/service/handlers/create_backup.rs

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled(); await this.ensureAndroidPushNotifsEnabled();
} }
} }
async ensureAndroidPushNotifsEnabled() { async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase(); const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission(); const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) { if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
return; return;
} }
}
const fcmToken = await firebase.messaging().getToken(); const fcmToken = await firebase.messaging().getToken();
if (fcmToken) { if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken); await this.handleAndroidDeviceToken(fcmToken);
} else { } else {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
} }
} }
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

services/backup/src/service/handlers/pull_backup.rs

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled(); await this.ensureAndroidPushNotifsEnabled();
} }
} }
async ensureAndroidPushNotifsEnabled() { async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase(); const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission(); const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) { if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
return; return;
} }
}
const fcmToken = await firebase.messaging().getToken(); const fcmToken = await firebase.messaging().getToken();
if (fcmToken) { if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken); await this.handleAndroidDeviceToken(fcmToken);
} else { } else {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
} }
} }
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

services/backup/src/service/handlers/send_log.rs

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines if (Platform.OS === 'ios') {
await this.ensureAndroidPushNotifsEnabled(); await this.ensureAndroidPushNotifsEnabled();
} }
} }
async ensureAndroidPushNotifsEnabled() { async ensureAndroidPushNotifsEnabled() {
const firebase = getFirebase(); const firebase = getFirebase();
const hasPermission = await firebase.messaging().hasPermission(); const hasPermission = await firebase.messaging().hasPermission();
if (!hasPermission) { if (!hasPermission) {
try {
await firebase.messaging().requestPermission();
} catch {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
return; return;
} }
}
const fcmToken = await firebase.messaging().getToken(); const fcmToken = await firebase.messaging().getToken();
if (fcmToken) { if (fcmToken) {
await this.handleAndroidDeviceToken(fcmToken); await this.handleAndroidDeviceToken(fcmToken);
} else { } else {
this.failedToRegisterPushPermissions(); this.failedToRegisterPushPermissions();
} }
} }
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

services/backup/src/service/mod.rs

Loading...