Page MenuHomePhabricator
Differential D6383

[backup-service] Rename 'PutClient' to 'BlobUploader'
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:13 AM.
Tags
None
Referenced Files
F1870129: D6383.id.diff
Sun, May 26, 10:24 PM
F1870099: D6383.diff
Sun, May 26, 10:21 PM
Unknown Object (File)
Fri, May 24, 6:38 AM
Unknown Object (File)
Fri, May 24, 6:20 AM
Unknown Object (File)
Fri, May 24, 6:20 AM
Unknown Object (File)
Apr 24 2024, 4:55 PM
Unknown Object (File)
Apr 3 2024, 12:10 AM
Unknown Object (File)
Apr 3 2024, 12:10 AM
View All 59 Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
michal
tomek
Commits
rCOMM75bef826f30b: [backup-service] Rename 'PutClient' to 'BlobUploader'
Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Renamed PutClient to BlobUploader, because this name is more accurate - these instances are not clients, but rather single RPC call instances. Also, old name could easily be confused with real Blob Client instance, introduced in further diffs.

Depends on D6382

Test Plan

Backup service compiles and starts.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
blob/
4 lines
uploader.rs
put_client.rs
28 lines
service/
handlers/
8 lines
20 lines
20 lines

Diff 21654

View Options

services/backup/src/blob/mod.rs

Loading...
View Options

services/backup/src/blob/put_client.rs

Loading...
View Options

services/backup/src/blob/uploader.rs

Loading...
View Options

services/backup/src/service/handlers/add_attachments.rs

Loading...
View Options

services/backup/src/service/handlers/create_backup.rs

Loading...
View Options

services/backup/src/service/handlers/send_log.rs

Loading...