Page MenuHomePhabricator
Differential D6386

[backup-service] Use shared 'BlobClient' in workers
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 1:34 PM
Unknown Object (File)
Wed, Mar 12, 3:33 AM
Unknown Object (File)
Wed, Mar 5, 10:37 PM
Unknown Object (File)
Wed, Mar 5, 10:37 PM
Unknown Object (File)
Wed, Mar 5, 10:36 PM
Unknown Object (File)
Wed, Mar 5, 10:30 PM
Unknown Object (File)
Feb 17 2025, 12:07 AM
Unknown Object (File)
Jan 31 2025, 3:05 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
michal
tomek
Commits
rCOMM20bce1cabf3a: [backup-service] Use shared 'BlobClient' in workers
Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Modified BlobDownloader::start and BlobUploader::start to take BlobClient as an argument instead of creating its own instance.

Depends on D6385

Test Plan

Ran backup service integration and performance tests to confirm it works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
blob/
13 lines
13 lines
service/
handlers/
8 lines
4 lines
2 lines
8 lines

Diff 21657

View Options

services/backup/src/blob/downloader.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/backup/src/blob/uploader.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/backup/src/service/handlers/add_attachments.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/backup/src/service/handlers/create_backup.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/backup/src/service/handlers/pull_backup.rs

Loading...
View Options

services/backup/src/service/handlers/send_log.rs

Loading...