HomePhabricator
Diffusion Comm 917c84f2c3d2

[landing] Add `openConnectModal` truthiness check before calling function

Tags
None
Referenced Files
F304010: 3ebbf5.png
Dec 25 2022, 3:47 PM
File Not Attached
Subscribers
None

Description

[landing] Add openConnectModal truthiness check before calling function

Summary:
Still encountering the issue described here: https://linear.app/comm/issue/ENG-2539/encountering-openconnectmodal-is-not-a-function-when-attempting-to

Modifying it to:

3ebbf5.png (216×710 px, 36 KB)

got things working again, but not sure if this is a solid solution.

Don't want to get sidetracked by this issue at the moment so haven't really investigated, just wanted to get things back in a working state.


Depends on D6026

Test Plan: The error modal no longer appears.

Reviewers: ashoat, tomek

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D6027

Details

Provenance
atulAuthored on Dec 25 2022, 3:40 PM
Reviewer
ashoat
Differential Revision
D6027: [landing] Add `openConnectModal` truthiness check before calling function
Parents
rCOMM54fcc7b8feb1: [keyserver] Add `isValidSIWENonce` check to `landingResponder`
Branches
Unknown
Tags
Unknown