Page MenuHomePhabricator
Differential D6027

[landing] Add `openConnectModal` truthiness check before calling function
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:18 PM
Unknown Object (File)
Wed, Dec 18, 6:18 PM
Unknown Object (File)
Wed, Dec 18, 6:18 PM
Unknown Object (File)
Wed, Dec 18, 6:18 PM
Unknown Object (File)
Nov 24 2024, 2:41 PM
Unknown Object (File)
Nov 10 2024, 5:59 PM
Unknown Object (File)
Nov 10 2024, 5:55 PM
Unknown Object (File)
Nov 5 2024, 4:19 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM917c84f2c3d2: [landing] Add `openConnectModal` truthiness check before calling function
Summary

Still encountering the issue described here: https://linear.app/comm/issue/ENG-2539/encountering-openconnectmodal-is-not-a-function-when-attempting-to

Modifying it to:

3ebbf5.png (216×710 px, 36 KB)

got things working again, but not sure if this is a solid solution.

Don't want to get sidetracked by this issue at the moment so haven't really investigated, just wanted to get things back in a working state.

Depends on D6026

Test Plan

The error modal no longer appears.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:00 PM
atul added a parent revision: D6026: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`.
atul added a child revision: D6028: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is signed.
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:02 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 24 2022, 8:11 PM
Harbormaster failed remote builds in B14737: Diff 20101!
Harbormaster completed remote builds in B14737: Diff 20101.Dec 24 2022, 8:22 PM
atul requested review of this revision.Dec 24 2022, 8:22 PM
ashoat accepted this revision.Dec 25 2022, 2:40 PM
ashoat added inline comments.
landing/siwe.react.js
96–98 ↗(On Diff #20101)

Nit, I prefer either of these:

if (hasNonce && openConnectModal) {
  openConnectModal();
}
if (hasNonce) {
  openConnectModal?.();
}
This revision is now accepted and ready to land.Dec 25 2022, 2:40 PM
atul updated this revision to Diff 20111.Dec 25 2022, 3:42 PM

rebase (before addressing feedback)

atul updated this revision to Diff 20112.Dec 25 2022, 3:43 PM

rebase before landing (after addressing feedback)

atul removed a child revision: D6028: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is signed.Dec 25 2022, 3:45 PM
atul removed a parent revision: D6026: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`.
This revision was landed with ongoing or failed builds.Dec 25 2022, 3:47 PM
Closed by commit rCOMM917c84f2c3d2: [landing] Add `openConnectModal` truthiness check before calling function (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM917c84f2c3d2: [landing] Add `openConnectModal` truthiness check before calling function.
Harbormaster completed remote builds in B14747: Diff 20111.Dec 25 2022, 3:56 PM
Harbormaster completed remote builds in B14748: Diff 20112.

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 20113

View Options

landing/siwe.react.js

Loading...