Page MenuHomePhabricator
Differential D6028

[native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is signed
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 10:48 PM
Unknown Object (File)
Feb 23 2025, 8:32 PM
Unknown Object (File)
Feb 17 2025, 8:58 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMc322654268c3: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is…
Summary

Modify SIWEPanel to hit the siwe_auth endpoint instead of the create_account endpoint once SIWE message is signed.

We also modify the SIWE_AUTH_SUCCESS payload to a boolean indicating whether the signed message is valid and login/registration can continue.

NOTE: For now we will return from siweAuthResponder BEFORE login/registration... login/registration will come later at which point the payload for SIWE_AUTH_SUCCESS will look like RegisterResponse | LogInResponse or something.

Depends on D6026

Test Plan

Able to hit the endpoint and verify that the request payload is as expected:
https://blob.sh/58459b.png

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:00 PM
atul added a parent revision: D6027: [landing] Add `openConnectModal` truthiness check before calling function.
atul added a child revision: D6029: [keyserver] Introduce `isValidEthereumAddress`.
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B14738: Diff 20102.Dec 24 2022, 8:12 PM
atul requested review of this revision.Dec 24 2022, 8:12 PM
atul edited the summary of this revision. (Show Details)Dec 25 2022, 3:45 PM
atul added a parent revision: D6026: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`.
atul removed a parent revision: D6027: [landing] Add `openConnectModal` truthiness check before calling function.
ashoat accepted this revision.Dec 25 2022, 7:23 PM

Awesome!!

This revision is now accepted and ready to land.Dec 25 2022, 7:23 PM
atul updated this revision to Diff 20131.Dec 27 2022, 12:29 AM

rebase before addressing feedback

Harbormaster failed remote builds in B14759: Diff 20131!Dec 27 2022, 12:31 AM
atul updated this revision to Diff 20132.Dec 27 2022, 12:34 AM

address feedback

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:40 AM
Closed by commit rCOMMc322654268c3: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc322654268c3: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is….
Harbormaster completed remote builds in B14760: Diff 20132.Dec 27 2022, 12:45 AM

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
account/
24 lines

Diff 20133

View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

native/account/siwe-panel.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm