Page MenuHomePhabricator
Differential D6031

[keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:22 AM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 3:48 PM
Unknown Object (File)
Fri, Nov 8, 3:48 PM
Unknown Object (File)
Tue, Nov 5, 4:20 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in…
Summary

Check that the values in SIWEMessage are as expected. Throw a ServerError in siweAuthResponder if not.

Depends on D6030

Test Plan

Tried calling the endpoint with various inputs (correct and malformed). Set breakpoints throughout and ensured that things worked as expected.

Also moved siweStatement to lib so it could be shared outside of native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 24 2022, 7:59 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM
atul added a parent revision: D6030: [lib] Introduce `SIWEMessage` type.
Harbormaster completed remote builds in B14741: Diff 20105.Dec 24 2022, 8:13 PM
atul requested review of this revision.Dec 24 2022, 8:13 PM
atul added a child revision: D6032: [keyserver] Introduce `checkAndInvalidateSIWENonceEntry` and consume in `siweAuthResponder`.Dec 24 2022, 10:30 PM
ashoat accepted this revision.Dec 25 2022, 7:25 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM
atul updated this revision to Diff 20138.Dec 27 2022, 12:51 AM

address feedback

atul updated this revision to Diff 20139.Dec 27 2022, 12:52 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:52 AM
Closed by commit rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in….
Harbormaster completed remote builds in B14763: Diff 20138.Dec 27 2022, 1:04 AM
Harbormaster completed remote builds in B14764: Diff 20139.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
11 lines
landing/
7 lines
lib/
utils/
29 lines

Diff 20140

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

landing/siwe.react.js

Loading...
View Options

lib/utils/siwe-utils.js

Loading...