Details

Reviewers

tomek
ashoat

Commits

rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type

Summary

Effectively copied from the TypeScript types:

Will be helpful to type return value of new SiweMessage(message) in siweAuthResponder as SIWEMessage.

Depends on D6029

Test Plan

Careful reading

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 25 2022, 3:58 AM

atul edited the summary of this revision. (Show Details)Dec 25 2022, 4:01 AM

atul added a parent revision: D6029: [keyserver] Introduce `isValidEthereumAddress`.

atul added a child revision: D6031: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`.

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B14740: Diff 20104.Dec 25 2022, 4:13 AM

atul requested review of this revision.Dec 25 2022, 4:13 AM

Will type the parts of siwe library we use properly w/ flow-typed in a subsequent diff once everything is working.

ashoat accepted this revision.Dec 26 2022, 3:25 AM

This revision is now accepted and ready to land.Dec 26 2022, 3:25 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 8:47 AM

Closed by commit rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type.

Harbormaster completed remote builds in B14762: Diff 20136.Dec 27 2022, 9:00 AM

[lib] Introduce `SIWEMessage` type
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 20137

lib/types/siwe-types.js

[lib] Introduce `SIWEMessage` typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20137

lib/types/siwe-types.js

[lib] Introduce `SIWEMessage` type
ClosedPublic
Actions

Revision Contents
Changeset List