Page MenuHomePhabricator
Differential D6031

[keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 7:30 AM
Unknown Object (File)
Mon, Apr 21, 4:32 AM
Unknown Object (File)
Mon, Apr 21, 2:38 AM
Unknown Object (File)
Sun, Apr 20, 10:02 PM
Unknown Object (File)
Sun, Apr 20, 8:30 PM
Unknown Object (File)
Sun, Apr 20, 2:19 PM
Unknown Object (File)
Tue, Apr 15, 12:10 AM
Unknown Object (File)
Tue, Apr 15, 12:10 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in…
Summary

Check that the values in SIWEMessage are as expected. Throw a ServerError in siweAuthResponder if not.

Depends on D6030

Test Plan

Tried calling the endpoint with various inputs (correct and malformed). Set breakpoints throughout and ensured that things worked as expected.

Also moved siweStatement to lib so it could be shared outside of native.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6031 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:59 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM
atul added a parent revision: D6030: [lib] Introduce `SIWEMessage` type.
Harbormaster completed remote builds in B14741: Diff 20105.Dec 24 2022, 8:13 PM
atul requested review of this revision.Dec 24 2022, 8:13 PM
atul added a child revision: D6032: [keyserver] Introduce `checkAndInvalidateSIWENonceEntry` and consume in `siweAuthResponder`.Dec 24 2022, 10:30 PM
ashoat accepted this revision.Dec 25 2022, 7:25 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM
atul updated this revision to Diff 20138.Dec 27 2022, 12:51 AM

address feedback

atul updated this revision to Diff 20139.Dec 27 2022, 12:52 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:52 AM
Closed by commit rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8b26e15c7991: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in….
Harbormaster completed remote builds in B14763: Diff 20138.Dec 27 2022, 1:04 AM
Harbormaster completed remote builds in B14764: Diff 20139.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
11 lines
landing/
7 lines
lib/
utils/
29 lines

Diff 20139

View Options

keyserver/src/responders/user-responders.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

landing/siwe.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm
View Options

lib/utils/siwe-utils.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Linesclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {
openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override; openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;
double getCodeVersion(jsi::Runtime &rt) override; double getCodeVersion(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override; setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;
jsi::Value clearNotifyToken(jsi::Runtime &rt) override; jsi::Value clearNotifyToken(jsi::Runtime &rt) override;
jsi::Value jsi::Value
setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override; setCurrentUserID(jsi::Runtime &rt, const jsi::String &userID) override;
jsi::Value getCurrentUserID(jsi::Runtime &rt) override; jsi::Value getCurrentUserID(jsi::Runtime &rt) override;
jsi::Value
setDeviceID(jsi::Runtime &rt, const jsi::String &deviceType) override;
jsi::Value getDeviceID(jsi::Runtime &rt) override;
jsi::Value clearSensitiveData(jsi::Runtime &rt) override; jsi::Value clearSensitiveData(jsi::Runtime &rt) override;
public: public:
CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker); CommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
void initializeNetworkModule( void initializeNetworkModule(
const std::string &userId, const std::string &userId,
const std::string &deviceToken, const std::string &deviceToken,
const std::string &hostname = ""); const std::string &hostname = "");
}; };
} // namespace comm } // namespace comm