HomePhabricator
Diffusion Comm 93e0b12f8445

[native] Introduce migration to unshim `MULTIMEDIA` messages

Tags
None
Referenced Files
F246215: d90055.png
Nov 17 2022, 10:09 AM
File Not Attached
F246217: 9a5b3f.png
Nov 17 2022, 10:09 AM
File Not Attached
Subscribers
None

Description

[native] Introduce migration to unshim MULTIMEDIA messages

Summary:
Context: https://linear.app/comm/issue/ENG-2270/handle-unshimming-of-multimedia-messages-on-native

This migration handles "unshimming" UNSUPPORTED messages that wrap MULTIMEDIA messages for clients upgrading from an old client to one that supports video messages.


Depends on D5637

Test Plan:
Set breakpoints and ensured that values were as expected at each point.

  1. Sent video message to native client that didn't support video messages and observed UNSUPPORTED message in Redux that wrapped MULTIMEDIA message.

9a5b3f.png (928×1 px, 163 KB)

  1. Bumped Redux persist version to trigger migration.
  1. Observed that UNSUPPORTED message was replaced by "unshimmed` MULTIMEDIA message.

d90055.png (632×1 px, 112 KB)

I'll do a lot more additional testing before landing.

Reviewers: tomek, marcin, ginsu, rohan, kamil, ashoat

Reviewed By: ashoat

Subscribers: ashoat, abosh

Differential Revision: https://phab.comm.dev/D5638

Details