Differential D5638
[native] Introduce migration to unshim `MULTIMEDIA` messages Authored by atul on Nov 15 2022, 10:00 PM. Tags None Referenced Files
Details Context: https://linear.app/comm/issue/ENG-2270/handle-unshimming-of-multimedia-messages-on-native This migration handles "unshimming" UNSUPPORTED messages that wrap MULTIMEDIA messages for clients upgrading from an old client to one that supports video messages. Depends on D5637 Set breakpoints and ensured that values were as expected at each point.
 I'll do a lot more additional testing before landing.
Diff Detail
Event TimelineComment Actions Had a long argument with @atul about this... I think it's a really bad solution beacause it requires calling commCoreModule.getAllMessagesSync() a second time (first time is in SQLiteContextProvider) and because the logic here really has nothing to do with redux-persist. I would've preferred doing this in C++, but Atul pointed out that would take a lot more time to write because the code we have for separating a RawMessageInfo (JS) into a message and a list of media (C++) only exists in JS today. Another option would've been to do this in SQLiteContextProvider, but Atul's argument there was that we have no migrations mechanism in SQLiteContextProvider. Our plan right now is to land this as-is and reevaluate at the end of the month if there is a better place we can put it. Atul estimates it would take 2-3 days to do this properly in the C++ side (ie. as a SQLite migration). Comment Actions Created Linear task to track reevaluating unshimming approach later in the month: https://linear.app/comm/issue/ENG-2281/reevaluate-multimedia-unshimming-approach |