Page MenuHomePhabricator
Differential D6023

[native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB
ClosedPublic
Actions

Authored by atul on Dec 23 2022, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 12:41 AM
Unknown Object (File)
Wed, Jun 26, 3:20 PM
Unknown Object (File)
Tue, Jun 25, 12:02 AM
Unknown Object (File)
Sun, Jun 23, 11:06 AM
Unknown Object (File)
Sat, Jun 22, 3:05 PM
Unknown Object (File)
Fri, Jun 21, 9:03 PM
Unknown Object (File)
Fri, Jun 21, 9:03 PM
Unknown Object (File)
Tue, Jun 11, 11:16 AM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
ashoat
Commits
rCOMM289a109d0544: [native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB
Summary

Basically D5638 but for REACTIONs instead of MULTIMEDIA messages.

Test Plan
  1. Uninstall Comm Messenger on my phone
  2. Install old build (app store one specifically)
  3. Observe the UNSUPPORTED message robotexts
  4. Deploy Release build to my phone (with these changes patched in)
  5. Observe that reactions show up as expected

Before:

IMG_F3374564E7C5-1.jpeg (2×1 px, 806 KB)

After:

IMG_809412A80C93-1.jpeg (2×1 px, 919 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 23 2022, 10:30 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 23 2022, 10:30 PM
atul published this revision for review.Dec 23 2022, 10:30 PM
Harbormaster completed remote builds in B14733: Diff 20097.Dec 23 2022, 10:44 PM
ashoat accepted this revision.Dec 25 2022, 6:52 PM
This revision is now accepted and ready to land.Dec 25 2022, 6:52 PM
ashoat added a comment.Dec 25 2022, 6:53 PM

Can you:

  1. Actually test before landing?
  2. Create a task (or address in a diff) this chat message you sent before landing?

there’s a ton of logic in common with the previous migration so probably worth pulling out the common logic as well

ginsu accepted this revision.Dec 25 2022, 7:22 PM

Task is here

atul retitled this revision from [DRAFT][native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB to [native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB.Dec 25 2022, 7:36 PM
atul edited the test plan for this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)Dec 25 2022, 7:50 PM
Closed by commit rCOMM289a109d0544: [native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB (authored by atul). · Explain WhyDec 25 2022, 7:51 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM289a109d0544: [native] Unshim `UNSUPPORTED` `REACTION` messages stored in clientDB.

Revision Contents
Changeset List

PathSize
native/
redux/
44 lines

Diff 20118

View Options

native/redux/persist.js

Loading...