HomePhabricator
Diffusion Comm 96800eb9c03f

Added web tests to .lintstagedrc and CI

Description

Added web tests to .lintstagedrc and CI

Summary:
Discussed in https://linear.app/comm/issue/ENG-2712/we-dont-run-tests-in-web-and-native-in-precommit-hook
After the tests are fixed by D7019, they can be added to pre-commit and CI

CI: did what suggested here: https://phab.comm.dev/D7019#208162

Depends on D7019.

Previous description by @przemek:

Title sums up it pretty well. Adding it runs tests in those workspaces during precommit hook.
Right now we don't have any tests in native and desktop yet, but it won't hurt to run them if they are created.
Adding @ashoat as this change important part of CI.

Test Plan:

  • Added dummy change that broke tests in the web directory.
  • Ran lint-staged -d -v
  • ensured that it fails
  • Fixed the issue and checked lint-staged again

Buildkite is tested by this diff

Did not test GH action

Reviewers: ashoat, atul, michal, kamil

Reviewed By: ashoat, atul

Subscribers: przemek, tomek, atul, ashoat

Differential Revision: https://phab.comm.dev/D6558

Details

Provenance
bartekAuthored on Mar 9 2023, 10:41 AM
Reviewer
ashoat
Differential Revision
D6558: Added web tests to .lintstagedrc and CI
Parents
rCOMM961052269b9f: [web] Fix missing WebCrypto mock in tests
Branches
Unknown
Tags
Unknown