HomePhabricator
Diffusion Comm 98095d9171f2

[RN72] Remove deprecated ESLint formatting rules

Description

[RN72] Remove deprecated ESLint formatting rules

Summary:
In ESLint 8.53, formatting rules are deprecated in favor of using Prettier for formatting.

D10538 updates us to 8.56.0, but the formatting rules won't be removed from ESLint until at least version 10. However, I figured now was as good a time as any to replace these rules.

We had three rules that are in the deprecated list. Of those, two of them aren't needed, since they're handled by Prettier: linebreak-style and semi.

We actually use max-len, however. Its use is explained in the comments of .eslintrc.json... basically, Prettier won't enforce limits on comment length.

ESLint's suggested migration path is to use @stylistic/eslint-plugin-js for this.

Depends on D10545

Test Plan: I edited a comment in a random JS file to be longer than 80 chars and confirmed that ESLint failed on it

Reviewers: atul

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10546

Details

Provenance
ashoatAuthored on Jan 4 2024, 1:50 PM
Reviewer
atul
Differential Revision
D10546: [RN72] Remove deprecated ESLint formatting rules
Parents
rCOMM92a03287b8f9: [RN72] Update Jest Flow libdefs
Branches
Unknown
Tags
Unknown