Page MenuHomePhabricator
Differential D10545

[RN72] Update Jest Flow libdefs
ClosedPublic
Actions

Authored by ashoat on Jan 4 2024, 12:53 PM.
Tags
None
Referenced Files
F3399235: D10545.diff
Mon, Dec 2, 2:34 AM
Unknown Object (File)
Sat, Nov 23, 6:50 PM
Unknown Object (File)
Sat, Nov 16, 7:12 AM
Unknown Object (File)
Thu, Nov 14, 3:07 PM
Unknown Object (File)
Thu, Nov 14, 9:41 AM
Unknown Object (File)
Oct 31 2024, 5:22 AM
Unknown Object (File)
Oct 18 2024, 2:46 PM
Unknown Object (File)
Oct 18 2024, 12:50 PM
View All 59 Files
Subscribers
atul
tomek

Details

Reviewers
atul
Commits
rCOMM92a03287b8f9: [RN72] Update Jest Flow libdefs
Summary

@atul called out that these libdefs are outdated in D10536. This diff updates them all to the latest version.

I updated the libdefs by first running git rm on each of them, and then running flow-typed install jest in each of the directories.

I also noticed that web was missing the libdef, so I added it.

Not sure these libdefs are currently used, but better to keep them updated then out-of-date, especially if we ever introduce any usages in the future.

Depends on D10544

Test Plan

Ran yarn flow-all from the workspace root. Also CI will run on this diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 4 2024, 12:53 PM
Herald added a subscriber: tomek. · View Herald TranscriptJan 4 2024, 12:53 PM
ashoat mentioned this in D10536: [RN72][skip-ci] Update Jest to 29.Jan 4 2024, 12:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2024, 1:06 PM
Harbormaster failed remote builds in B25502: Diff 35219!
ashoat updated this revision to Diff 35222.Jan 4 2024, 1:41 PM

Rebase

ashoat added a child revision: D10546: [RN72] Remove deprecated ESLint formatting rules.Jan 4 2024, 1:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2024, 1:54 PM
Harbormaster failed remote builds in B25505: Diff 35222!
ashoat updated this revision to Diff 35226.Jan 4 2024, 1:58 PM

Rebase

Harbormaster completed remote builds in B25509: Diff 35226.Jan 4 2024, 2:17 PM
ashoat requested review of this revision.Jan 4 2024, 2:17 PM
atul accepted this revision.Jan 4 2024, 2:51 PM

Rubberstamping

This revision is now accepted and ready to land.Jan 4 2024, 2:51 PM
Closed by commit rCOMM92a03287b8f9: [RN72] Update Jest Flow libdefs (authored by ashoat). · Explain WhyJan 4 2024, 6:12 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM92a03287b8f9: [RN72] Update Jest Flow libdefs.

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
jest_v29.x.x.js
jest_v26.x.x.js
55 lines
lib/
flow-typed/
npm/
jest_v29.x.x.js
jest_v26.x.x.js
55 lines
native/
flow-typed/
npm/
jest_v29.x.x.js
jest_v24.x.x.js
273 lines
web/
flow-typed/
npm/
keyserver/
flow-typed/
npm/
jest_v29.x.x.js
jest_v26.x.x.js
55 lines

Diff 35245

View Options

keyserver/flow-typed/npm/jest_v26.x.x.js

Loading...
View Options

keyserver/flow-typed/npm/jest_v29.x.x.js

Loading...
View Options

lib/flow-typed/npm/jest_v26.x.x.js

Loading...
View Options

lib/flow-typed/npm/jest_v29.x.x.js

Loading...
View Options

native/flow-typed/npm/jest_v24.x.x.js

Loading...
View Options

native/flow-typed/npm/jest_v29.x.x.js

Loading...
View Options

web/flow-typed/npm/jest_v29.x.x.js

Loading...