Page MenuHomePhabricator

[RN72][skip-ci] Rename eslint NPM script to eslint:all
ClosedPublic

Authored by ashoat on Jan 4 2024, 12:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 5:22 AM
Unknown Object (File)
Tue, Oct 15, 7:58 PM
Unknown Object (File)
Oct 5 2024, 7:35 PM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Subscribers

Details

Summary

By overloading the eslint name, we make it impossible to run eslint from the root on a specific file.

To avoid that issue, this diff renames the eslint script name to eslint:all. Now invocations of yarn eslint will go straight to the package binary, which allows us to run it on a specific file, eg.:

yarn eslint --fix native/chat/swipeable-message.react.js

Depends on D10540

Test Plan

Try yarn eslint --fix native/chat/swipeable-message.react.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

package.json
20 ↗(On Diff #35214)

For flow and jest we do flow-all and jest-all, maybe we should switch those over to colon as well?

This revision is now accepted and ready to land.Jan 4 2024, 2:35 PM
This revision was landed with ongoing or failed builds.Jan 4 2024, 6:12 PM
This revision was automatically updated to reflect the committed changes.