HomePhabricator
Diffusion Comm 9d943b733b4b

[web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`

Tags
None
Referenced Files
F50848: Screen Shot 2022-05-05 at 10.00.46 AM.png
May 5 2022, 9:18 AM
F50847: Screen Shot 2022-05-05 at 10.00.34 AM.png
May 5 2022, 9:18 AM
Subscribers
None

Description

[web] Move padding from modal_body to tab_body in ThreadSettingsModal

Summary:
We want each of the ThreadSettingsBlahTab components to have some padding so their contents aren't right against the edge of the surrounding Modal. However, we do want the Tabs to extend all the way to the edges and be closer to the Modal header.

We can't put these divs inside <Tabs.Container> because it expects its children to be typed a certain way. As a result we have to copy/paste the <div className={css.tab_body}> tag for every tab. We could move this padding to the children Tab components themselves, but setting the padding in ThreadSettingsModal seems like the right layer of abstraction to me.


Depends on D3929

Test Plan:
Before:

Screen Shot 2022-05-05 at 10.00.34 AM.png (1×712 px, 74 KB)

After:

Screen Shot 2022-05-05 at 10.00.46 AM.png (1×712 px, 75 KB)

Reviewers: ashoat, palys-swm

Reviewed By: ashoat

Subscribers: Adrian, karol-bisztyga, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3930

Details

Provenance
atulAuthored on May 5 2022, 7:01 AM
Reviewer
ashoat
Differential Revision
D3930: [web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`
Parents
rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`
Branches
Unknown
Tags
Unknown