Paths

Table of Contentst

-
web/modals/threads/
-
modals/
-
threads/
-
thread-settings-modal.css

Differential D3929

[web] Remove unused styles from `thread-settings-modal.css`
ClosedPublic
Actions

Authored by atul on May 5 2022, 6:43 AM.

Tags

None

Referenced Files

	F4948058: D3929.diff
	Wed, Mar 19, 7:22 PM

	Unknown Object (File)
	Wed, Mar 12, 9:50 PM

	Unknown Object (File)
	Tue, Feb 25, 7:21 PM

	Unknown Object (File)
	Fri, Feb 21, 5:48 AM

	Unknown Object (File)
	Tue, Feb 18, 11:41 AM

	Unknown Object (File)
	Feb 8 2025, 10:14 AM

	Unknown Object (File)
	Jan 28 2025, 1:07 AM

	Unknown Object (File)
	Jan 22 2025, 3:49 AM

Subscribers

Details

Reviewers

ashoat
tomek

Commits

rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`

Summary

Really should have been part of D3845 when I removed the old tabs. But basically cut the unused styles left over from the removed Tabs component.

Depends on D3928

Test Plan

No occurences of tab_panel in the codebase

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 5 2022, 6:43 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 6:43 AM

atul published this revision for review.May 5 2022, 6:46 AM

Harbormaster completed remote builds in B8810: Diff 12276.May 5 2022, 6:49 AM

atul added a child revision: D3930: [web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`.May 5 2022, 7:09 AM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D3928: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components.

also remove modal_body p and save_button

atul retitled this revision from [web] Remove unused `tab_panel` styles to [web] Remove unused styles from `thread-settings-modal.css`.May 5 2022, 7:20 AM

Harbormaster completed remote builds in B8813: Diff 12280.May 5 2022, 7:24 AM

ashoat accepted this revision.May 5 2022, 8:56 AM

This revision is now accepted and ready to land.May 5 2022, 8:56 AM

Closed by commit rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css` (authored by atul). · Explain WhyMay 5 2022, 9:17 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.css

26 lines

Diff 12295

web/modals/threads/thread-settings-modal.css

Loading...