Paths

Table of Contentst

Differential D3929

[web] Remove unused styles from `thread-settings-modal.css`
ClosedPublic
Actions

Authored by atul on May 5 2022, 1:43 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

ashoat
tomek

Commits

rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`

Summary

Really should have been part of D3845 when I removed the old tabs. But basically cut the unused styles left over from the removed Tabs component.

Depends on D3928

Test Plan

No occurences of tab_panel in the codebase

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 5 2022, 1:43 PM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 1:43 PM

atul published this revision for review.May 5 2022, 1:46 PM

Harbormaster completed remote builds in B8810: Diff 12276.May 5 2022, 1:49 PM

atul added a child revision: D3930: [web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`.May 5 2022, 2:09 PM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D3928: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components.

also remove modal_body p and save_button

atul retitled this revision from [web] Remove unused `tab_panel` styles to [web] Remove unused styles from `thread-settings-modal.css`.May 5 2022, 2:20 PM

Harbormaster completed remote builds in B8813: Diff 12280.May 5 2022, 2:24 PM

ashoat accepted this revision.May 5 2022, 3:56 PM

This revision is now accepted and ready to land.May 5 2022, 3:56 PM

Closed by commit rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`. · Explain WhyMay 5 2022, 4:17 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa3020d2066cd: [web] Remove unused styles from `thread-settings-modal.css`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.css

26 lines

Diff 12295

web/modals/threads/thread-settings-modal.css

Loading...