Page MenuHomePhabricator

[web] Move `modal_form_error` within `tab_body`
ClosedPublic

Authored by atul on May 5 2022, 8:45 AM.
Tags
None
Referenced Files
F3345292: D3934.id12289.diff
Fri, Nov 22, 5:45 AM
Unknown Object (File)
Wed, Nov 20, 1:49 AM
Unknown Object (File)
Thu, Nov 14, 4:28 AM
Unknown Object (File)
Mon, Nov 11, 5:32 AM
Unknown Object (File)
Sat, Nov 9, 7:11 PM
Unknown Object (File)
Tue, Nov 5, 7:19 AM
Unknown Object (File)
Tue, Nov 5, 7:19 AM
Unknown Object (File)
Tue, Nov 5, 4:46 AM

Details

Summary

We want the error message to appear "within" the tab_body so it isn't pushed to the outer edge of the Modal. This required "copy/pasting" the error message div three times... couldn't think of a way around this because only Tabs.Item components can be nested within Tabs.Container.

Note: As an aside, I think displaying the error message within the "Save" button could be cleaner and keep the layout simpler. We do something like this on landing with the SubscriptionForm component. Not saying we should prioritize this right now, but just thought it might look cleaner. Might looks something like:

fedf-1.png (1×748 px, 83 KB)


Depends on D3933

Test Plan

Here's what it looks like:

Before:

Screen Shot 2022-05-05 at 11.32.43 AM.png (1×712 px, 78 KB)

After:

Screen Shot 2022-05-05 at 11.32.52 AM.png (1×712 px, 78 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.May 5 2022, 8:46 AM
atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
atul added reviewers: ashoat, tomek.
This revision is now accepted and ready to land.May 5 2022, 9:00 AM