Page MenuHomePhabricator
Differential D3928

[web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
ClosedPublic
Actions

Authored by atul on May 5 2022, 6:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 9:59 AM
Unknown Object (File)
Sun, Mar 9, 9:04 AM
Unknown Object (File)
Jan 31 2025, 5:08 PM
Unknown Object (File)
Jan 31 2025, 3:59 AM
Unknown Object (File)
Jan 30 2025, 12:40 AM
Unknown Object (File)
Jan 20 2025, 4:06 AM
Unknown Object (File)
Jan 20 2025, 4:06 AM
Unknown Object (File)
Jan 1 2025, 7:09 PM
View All Files
Subscribers
• abosh
• adrian
• karol
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMMcb2b044b0ed6: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab"…
Summary

Addresses feedback from @palys-swm in a previous stack. Makes ThreadSettingsModal cleaner.

Test Plan

Things continue to look/work as expected:

6869.png (1×736 px, 77 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 12294

View Options

web/modals/threads/thread-settings-delete-tab.react.js

Show All 31 Lines
const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector( const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(
exactSearchUserActionTypes, exactSearchUserActionTypes,
); );
export type UsernameSelectionParams = { export type UsernameSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverURL: string,
}, },
}; };
type UsernameError = 'username_invalid' | 'username_taken'; type UsernameError = 'username_invalid' | 'username_taken';
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'UsernameSelection'>, +navigation: RegistrationNavigationProp<'UsernameSelection'>,
+route: NavigationRoute<'UsernameSelection'>, +route: NavigationRoute<'UsernameSelection'>,
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines
View Options

web/modals/threads/thread-settings-general-tab.react.js

Show All 31 Lines
const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector( const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(
exactSearchUserActionTypes, exactSearchUserActionTypes,
); );
export type UsernameSelectionParams = { export type UsernameSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverURL: string,
}, },
}; };
type UsernameError = 'username_invalid' | 'username_taken'; type UsernameError = 'username_invalid' | 'username_taken';
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'UsernameSelection'>, +navigation: RegistrationNavigationProp<'UsernameSelection'>,
+route: NavigationRoute<'UsernameSelection'>, +route: NavigationRoute<'UsernameSelection'>,
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines
View Options

web/modals/threads/thread-settings-modal.react.js

Show All 31 Lines
const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector( const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(
exactSearchUserActionTypes, exactSearchUserActionTypes,
); );
export type UsernameSelectionParams = { export type UsernameSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverURL: string,
}, },
}; };
type UsernameError = 'username_invalid' | 'username_taken'; type UsernameError = 'username_invalid' | 'username_taken';
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'UsernameSelection'>, +navigation: RegistrationNavigationProp<'UsernameSelection'>,
+route: NavigationRoute<'UsernameSelection'>, +route: NavigationRoute<'UsernameSelection'>,
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines
View Options

web/modals/threads/thread-settings-privacy-tab.react.js

Show All 31 Lines
const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector( const exactSearchUserLoadingStatusSelector = createLoadingStatusSelector(
exactSearchUserActionTypes, exactSearchUserActionTypes,
); );
export type UsernameSelectionParams = { export type UsernameSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverUsername: string, +keyserverURL: string,
}, },
}; };
type UsernameError = 'username_invalid' | 'username_taken'; type UsernameError = 'username_invalid' | 'username_taken';
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'UsernameSelection'>, +navigation: RegistrationNavigationProp<'UsernameSelection'>,
+route: NavigationRoute<'UsernameSelection'>, +route: NavigationRoute<'UsernameSelection'>,
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines