Page MenuHomePhabricator
Differential D3928

[web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
ClosedPublic
Actions

Authored by atul on May 5 2022, 6:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:38 PM
Unknown Object (File)
Thu, Nov 14, 4:37 PM
Unknown Object (File)
Mon, Nov 11, 6:54 AM
Unknown Object (File)
Sun, Nov 10, 7:46 AM
Unknown Object (File)
Sun, Nov 10, 7:33 AM
Unknown Object (File)
Sun, Nov 10, 4:42 AM
Unknown Object (File)
Sat, Nov 9, 10:47 PM
Unknown Object (File)
Fri, Nov 8, 1:43 AM
View All Files
Subscribers
• abosh
• adrian
• karol
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMMcb2b044b0ed6: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab"…
Summary

Addresses feedback from @palys-swm in a previous stack. Makes ThreadSettingsModal cleaner.

Test Plan

Things continue to look/work as expected:

6869.png (1×736 px, 77 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 12294

View Options

web/modals/threads/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/thread-settings-privacy-tab.react.js

Loading...