Paths

Table of Contentst

[web] Tweak layout of `ThreadSettingsGeneralTab`
ClosedPublic
Actions

Authored by atul on May 5 2022, 8:09 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM8a3cb15a75dc: [web] Tweak layout of `ThreadSettingsGeneralTab`

Summary

Make some tweaks to ThreadSettingsGeneralTab to space out the form elements a bit and in a more consistent way.

Depends on D3932

Test Plan

Here's how it looks before and after:

Before:

Screen Shot 2022-05-05 at 11.05.34 AM.png (1×712 px, 76 KB)

After:

Screen Shot 2022-05-05 at 11.05.21 AM.png (1×712 px, 74 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 5 2022, 8:09 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 8:09 AM

atul edited the summary of this revision. (Show Details)May 5 2022, 8:11 AM

atul added a parent revision: D3932: [web] Remove no longer relevant styles from `thread-settings-general-tab.css`.

Harbormaster completed remote builds in B8820: Diff 12288.May 5 2022, 8:14 AM

atul requested review of this revision.May 5 2022, 8:14 AM

atul edited the test plan for this revision. (Show Details)May 5 2022, 8:17 AM

atul added a child revision: D3934: [web] Move `modal_form_error` within `tab_body`.May 5 2022, 8:45 AM

ashoat accepted this revision.May 5 2022, 8:58 AM

This revision is now accepted and ready to land.May 5 2022, 8:58 AM

Closed by commit rCOMM8a3cb15a75dc: [web] Tweak layout of `ThreadSettingsGeneralTab` (authored by atul). · Explain WhyMay 5 2022, 9:21 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8a3cb15a75dc: [web] Tweak layout of `ThreadSettingsGeneralTab`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-general-tab.css

14 lines

thread-settings-general-tab.react.js

10 lines

thread-settings-modal.css

2 lines

Diff 12298

View Options

web/modals/threads/thread-settings-general-tab.css

View Options

web/modals/threads/thread-settings-general-tab.react.js

View Options

web/modals/threads/thread-settings-modal.css

[web] Tweak layout of `ThreadSettingsGeneralTab`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12298

web/modals/threads/thread-settings-general-tab.css

web/modals/threads/thread-settings-general-tab.react.js

web/modals/threads/thread-settings-modal.css

[web] Tweak layout of `ThreadSettingsGeneralTab`
ClosedPublic
Actions

Revision Contents
Changeset List