Paths
| Differential D3933 Authored by atul on May 5 2022, 8:09 AM.
Details Summary Make some tweaks to ThreadSettingsGeneralTab to space out the form elements a bit and in a more consistent way. Depends on D3932 Test Plan Here's how it looks before and after: Before:  After: 
Diff Detail
Event TimelineHerald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 8:09 AM2022-05-05 08:09:31 (UTC-7) atul edited the summary of this revision. (Show Details)May 5 2022, 8:11 AM2022-05-05 08:11:36 (UTC-7) atul added a parent revision: D3932: [web] Remove no longer relevant styles from `thread-settings-general-tab.css`. Harbormaster completed remote builds in B8820: Diff 12288.May 5 2022, 8:14 AM2022-05-05 08:14:00 (UTC-7) atul edited the test plan for this revision. (Show Details)May 5 2022, 8:17 AM2022-05-05 08:17:53 (UTC-7) atul added a child revision: D3934: [web] Move `modal_form_error` within `tab_body`.May 5 2022, 8:45 AM2022-05-05 08:45:41 (UTC-7) This revision is now accepted and ready to land.May 5 2022, 8:58 AM2022-05-05 08:58:49 (UTC-7) Closed by commit rCOMM8a3cb15a75dc: [web] Tweak layout of `ThreadSettingsGeneralTab` (authored by atul). · Explain WhyMay 5 2022, 9:21 AM2022-05-05 09:21:34 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12298 web/modals/threads/thread-settings-general-tab.css
web/modals/threads/thread-settings-general-tab.react.js
web/modals/threads/thread-settings-modal.css
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||