HomePhabricator
Diffusion Comm fb101e7aa77d

[web] Move `modal_form_error` within `tab_body`

Tags
None
Referenced Files
F50967: fedf-1.png
May 5 2022, 10:34 AM
F50968: Screen Shot 2022-05-05 at 11.32.43 AM.png
May 5 2022, 10:34 AM
F50969: Screen Shot 2022-05-05 at 11.32.52 AM.png
May 5 2022, 10:34 AM
Subscribers
None

Description

[web] Move modal_form_error within tab_body

Summary:
We want the error message to appear "within" the tab_body so it isn't pushed to the outer edge of the Modal. This required "copy/pasting" the error message div three times... couldn't think of a way around this because only Tabs.Item components can be nested within Tabs.Container.

Note: As an aside, I think displaying the error message within the "Save" button could be cleaner and keep the layout simpler. We do something like this on landing with the SubscriptionForm component. Not saying we should prioritize this right now, but just thought it might look cleaner. Might looks something like:

fedf-1.png (1×748 px, 83 KB)


Depends on D3933

Test Plan:
Here's what it looks like:

Before:

Screen Shot 2022-05-05 at 11.32.43 AM.png (1×712 px, 78 KB)

After:

Screen Shot 2022-05-05 at 11.32.52 AM.png (1×712 px, 78 KB)

Reviewers: ashoat, palys-swm

Reviewed By: ashoat

Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3934

Details

Provenance
atulAuthored on May 5 2022, 8:33 AM
Reviewer
ashoat
Differential Revision
D3934: [web] Move `modal_form_error` within `tab_body`
Parents
rCOMMea7b3df152a7: [chore] bump husky package
Branches
Unknown
Tags
Unknown