HomePhabricator
Diffusion Comm 9e1d87065616

[services][backup] PullBackup 3/5 - response buffer utility

Description

[services][backup] PullBackup 3/5 - response buffer utility

Summary:
First part of my attempt to separate transport and business logic, because it is terribly mixed in the C++ codebase.

This diff implements the ResponseBuffer utility struct which handles retrieving data chunks of arbitrary size. One of its functionalities is to reflect this C++ function.

Depends on D6241

Test Plan: This structure is used two diffls later and tested altogether with the whole endpoint. I'm wondering if it's worth adding unit tests here.

Reviewers: tomek, varun, jon, michal

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6242

Details

Provenance
bartekAuthored on Jan 11 2023, 1:34 PM
Reviewer
tomek
Differential Revision
D6242: [services][backup] PullBackup 3/5 - response buffer utility
Parents
rCOMM746b8bcbea88: [services][backup] PullBackup 2/5 - handler core logic
Branches
Unknown
Tags
Unknown