if find_log_items_for_backup took AsRef<str> as a parameter, then we wouldn't need to explicity do as_str()

Good catch, but in this case find_log_items_for_backup(&backup_item.backup_id) would work too - I don't remember why I used as_ref();

The find_log_items_for_backup looks like this:

fn find_log_items_for_backup(
    backup_id: &str,
) {
  let some_str: String = backup_id.to_string()
  // ...

In my opinion, in this case it'd be better to use Into<String> instead of AsRef:

fn find_log_items_for_backup(
    backup_id: impl Into<String>,
) {
  let some_str: String = backup_id.into()
  // ...

This should work for both slices and owned strings

I can create a starter task for this (find_log_items_for_backup is already landed)

Linear task: https://linear.app/comm/issue/ENG-2749/[services]-use-impl-intostring-for-database-methods