Page MenuHomePhabricator
Differential D5843

[services][backup] Scaffold gRPC server
ClosedPublic
Actions

Authored by bartek on Dec 8 2022, 4:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 10:07 PM
Unknown Object (File)
Fri, Mar 21, 3:57 PM
Unknown Object (File)
Sun, Mar 16, 2:34 PM
Unknown Object (File)
Fri, Mar 14, 11:47 AM
Unknown Object (File)
Mar 12 2025, 7:35 AM
Unknown Object (File)
Mar 5 2025, 4:45 PM
Unknown Object (File)
Mar 5 2025, 4:45 PM
Unknown Object (File)
Mar 5 2025, 4:45 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
tomek
• jon
Commits
rCOMM174fffba3a18: [services][backup] Scaffold gRPC server
Summary

Created gRPC handlers, added logging and server init code. Some copy-paste from blob service.

Depends on D5842

Test Plan

Service should respond with UNIMPLEMENTED to gRPC calls.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 8 2022, 4:11 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 8 2022, 4:11 AM
bartek published this revision for review.Dec 8 2022, 4:16 AM
Harbormaster completed remote builds in B14061: Diff 19248.Dec 8 2022, 4:23 AM
varun accepted this revision.Dec 9 2022, 9:13 AM

Can you explain what EnvFilters are and why we're using them here?

This revision is now accepted and ready to land.Dec 9 2022, 9:13 AM
bartek updated this revision to Diff 20570.Jan 4 2023, 5:38 AM
  • Rebase
  • Slightly cleaned up mod/use structure
bartek added a comment.Jan 4 2023, 5:44 AM
In D5843#174783, @varun wrote:

Can you explain what EnvFilters are and why we're using them here?

I explained them more in-depth in the description of this diff: https://phab.comm.dev/D5729 - the same code is already used in blob service
Basically, it allows you to use the RUST_LOG env var (default, configurable in constants.rs) to select displayed log level: trace/debug/info/warn/error.

Harbormaster completed remote builds in B15079: Diff 20570.Jan 4 2023, 5:51 AM
bartek added a child revision: D6161: [services][backup] Introduce cmdline args config.Jan 4 2023, 6:16 AM
bartek updated this revision to Diff 20603.Jan 5 2023, 3:38 AM

Fix typo (blob_service -> backup_service variable name)

Harbormaster completed remote builds in B15108: Diff 20603.Jan 5 2023, 3:53 AM
tomek accepted this revision.Jan 9 2023, 3:44 AM
Closed by commit rCOMM174fffba3a18: [services][backup] Scaffold gRPC server (authored by bartek). · Explain WhyJan 11 2023, 1:30 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM174fffba3a18: [services][backup] Scaffold gRPC server.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
3 lines
41 lines
service/
72 lines

Diff 20780

View Options

services/backup/src/constants.rs

Show First 20 Lines • Show All 638 Lines • ▼ Show 20 Lines return {
cookieInsertedThisRequest: true, cookieInsertedThisRequest: true,
isScriptViewer: false, isScriptViewer: false,
}; };
} }
type UserCookieCreationParams = { type UserCookieCreationParams = {
platformDetails: PlatformDetails, platformDetails: PlatformDetails,
deviceToken?: ?string, deviceToken?: ?string,
primaryIdentityPublicKey?: ?string,
}; };
// The result of this function should never be passed directly to the Viewer // The result of this function should never be passed directly to the Viewer
// constructor. Instead, it should be passed to viewer.setNewCookie. There are // constructor. Instead, it should be passed to viewer.setNewCookie. There are
// several fields on UserViewerData that are not set by this function: // several fields on UserViewerData that are not set by this function:
// sessionID, sessionIdentifierType, cookieSource, and ipAddress. These // sessionID, sessionIdentifierType, cookieSource, and ipAddress. These
// parameters all depend on the initial request. If the result of this function // parameters all depend on the initial request. If the result of this function
// is passed to the Viewer constructor directly, the resultant Viewer object // is passed to the Viewer constructor directly, the resultant Viewer object
// will throw whenever anybody attempts to access the relevant properties. // will throw whenever anybody attempts to access the relevant properties.
async function createNewUserCookie( async function createNewUserCookie(
userID: string, userID: string,
params: UserCookieCreationParams, params: UserCookieCreationParams,
): Promise<UserViewerData> { ): Promise<UserViewerData> {
const { platformDetails, deviceToken } = params; const { platformDetails, deviceToken, primaryIdentityPublicKey } = params;
const { platform, ...versions } = platformDetails || defaultPlatformDetails; const { platform, ...versions } = platformDetails || defaultPlatformDetails;
const versionsString = const versionsString =
Object.keys(versions).length > 0 ? JSON.stringify(versions) : null; Object.keys(versions).length > 0 ? JSON.stringify(versions) : null;
const time = Date.now(); const time = Date.now();
const cookiePassword = crypto.randomBytes(32).toString('hex'); const cookiePassword = crypto.randomBytes(32).toString('hex');
const cookieHash = bcrypt.hashSync(cookiePassword); const cookieHash = bcrypt.hashSync(cookiePassword);
const [[cookieID]] = await Promise.all([ const [[cookieID]] = await Promise.all([
createIDs('cookies', 1), createIDs('cookies', 1),
deviceToken ? clearDeviceToken(deviceToken) : undefined, deviceToken ? clearDeviceToken(deviceToken) : undefined,
]); ]);
const cookieRow = [ const cookieRow = [
cookieID, cookieID,
cookieHash, cookieHash,
userID, userID,
platform, platform,
time, time,
time, time,
deviceToken, deviceToken,
versionsString, versionsString,
primaryIdentityPublicKey,
]; ];
const query = SQL` const query = SQL`
INSERT INTO cookies(id, hash, user, platform, creation_time, last_used, INSERT INTO cookies(id, hash, user, platform, creation_time, last_used,
device_token, versions) device_token, versions, public_key)
VALUES ${[cookieRow]} VALUES ${[cookieRow]}
`; `;
await dbQuery(query); await dbQuery(query);
return { return {
loggedIn: true, loggedIn: true,
id: userID, id: userID,
platformDetails, platformDetails,
deviceToken, deviceToken,
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines
View Options

services/backup/src/main.rs

Show First 20 Lines • Show All 638 Lines • ▼ Show 20 Lines return {
cookieInsertedThisRequest: true, cookieInsertedThisRequest: true,
isScriptViewer: false, isScriptViewer: false,
}; };
} }
type UserCookieCreationParams = { type UserCookieCreationParams = {
platformDetails: PlatformDetails, platformDetails: PlatformDetails,
deviceToken?: ?string, deviceToken?: ?string,
primaryIdentityPublicKey?: ?string,
}; };
// The result of this function should never be passed directly to the Viewer // The result of this function should never be passed directly to the Viewer
// constructor. Instead, it should be passed to viewer.setNewCookie. There are // constructor. Instead, it should be passed to viewer.setNewCookie. There are
// several fields on UserViewerData that are not set by this function: // several fields on UserViewerData that are not set by this function:
// sessionID, sessionIdentifierType, cookieSource, and ipAddress. These // sessionID, sessionIdentifierType, cookieSource, and ipAddress. These
// parameters all depend on the initial request. If the result of this function // parameters all depend on the initial request. If the result of this function
// is passed to the Viewer constructor directly, the resultant Viewer object // is passed to the Viewer constructor directly, the resultant Viewer object
// will throw whenever anybody attempts to access the relevant properties. // will throw whenever anybody attempts to access the relevant properties.
async function createNewUserCookie( async function createNewUserCookie(
userID: string, userID: string,
params: UserCookieCreationParams, params: UserCookieCreationParams,
): Promise<UserViewerData> { ): Promise<UserViewerData> {
const { platformDetails, deviceToken } = params; const { platformDetails, deviceToken, primaryIdentityPublicKey } = params;
const { platform, ...versions } = platformDetails || defaultPlatformDetails; const { platform, ...versions } = platformDetails || defaultPlatformDetails;
const versionsString = const versionsString =
Object.keys(versions).length > 0 ? JSON.stringify(versions) : null; Object.keys(versions).length > 0 ? JSON.stringify(versions) : null;
const time = Date.now(); const time = Date.now();
const cookiePassword = crypto.randomBytes(32).toString('hex'); const cookiePassword = crypto.randomBytes(32).toString('hex');
const cookieHash = bcrypt.hashSync(cookiePassword); const cookieHash = bcrypt.hashSync(cookiePassword);
const [[cookieID]] = await Promise.all([ const [[cookieID]] = await Promise.all([
createIDs('cookies', 1), createIDs('cookies', 1),
deviceToken ? clearDeviceToken(deviceToken) : undefined, deviceToken ? clearDeviceToken(deviceToken) : undefined,
]); ]);
const cookieRow = [ const cookieRow = [
cookieID, cookieID,
cookieHash, cookieHash,
userID, userID,
platform, platform,
time, time,
time, time,
deviceToken, deviceToken,
versionsString, versionsString,
primaryIdentityPublicKey,
]; ];
const query = SQL` const query = SQL`
INSERT INTO cookies(id, hash, user, platform, creation_time, last_used, INSERT INTO cookies(id, hash, user, platform, creation_time, last_used,
device_token, versions) device_token, versions, public_key)
VALUES ${[cookieRow]} VALUES ${[cookieRow]}
`; `;
await dbQuery(query); await dbQuery(query);
return { return {
loggedIn: true, loggedIn: true,
id: userID, id: userID,
platformDetails, platformDetails,
deviceToken, deviceToken,
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines
View Options

services/backup/src/service/mod.rs

Show First 20 Lines • Show All 638 Lines • ▼ Show 20 Lines return {
cookieInsertedThisRequest: true, cookieInsertedThisRequest: true,
isScriptViewer: false, isScriptViewer: false,
}; };
} }
type UserCookieCreationParams = { type UserCookieCreationParams = {
platformDetails: PlatformDetails, platformDetails: PlatformDetails,
deviceToken?: ?string, deviceToken?: ?string,
primaryIdentityPublicKey?: ?string,
}; };
// The result of this function should never be passed directly to the Viewer // The result of this function should never be passed directly to the Viewer
// constructor. Instead, it should be passed to viewer.setNewCookie. There are // constructor. Instead, it should be passed to viewer.setNewCookie. There are
// several fields on UserViewerData that are not set by this function: // several fields on UserViewerData that are not set by this function:
// sessionID, sessionIdentifierType, cookieSource, and ipAddress. These // sessionID, sessionIdentifierType, cookieSource, and ipAddress. These
// parameters all depend on the initial request. If the result of this function // parameters all depend on the initial request. If the result of this function
// is passed to the Viewer constructor directly, the resultant Viewer object // is passed to the Viewer constructor directly, the resultant Viewer object
// will throw whenever anybody attempts to access the relevant properties. // will throw whenever anybody attempts to access the relevant properties.
async function createNewUserCookie( async function createNewUserCookie(
userID: string, userID: string,
params: UserCookieCreationParams, params: UserCookieCreationParams,
): Promise<UserViewerData> { ): Promise<UserViewerData> {
const { platformDetails, deviceToken } = params; const { platformDetails, deviceToken, primaryIdentityPublicKey } = params;
const { platform, ...versions } = platformDetails || defaultPlatformDetails; const { platform, ...versions } = platformDetails || defaultPlatformDetails;
const versionsString = const versionsString =
Object.keys(versions).length > 0 ? JSON.stringify(versions) : null; Object.keys(versions).length > 0 ? JSON.stringify(versions) : null;
const time = Date.now(); const time = Date.now();
const cookiePassword = crypto.randomBytes(32).toString('hex'); const cookiePassword = crypto.randomBytes(32).toString('hex');
const cookieHash = bcrypt.hashSync(cookiePassword); const cookieHash = bcrypt.hashSync(cookiePassword);
const [[cookieID]] = await Promise.all([ const [[cookieID]] = await Promise.all([
createIDs('cookies', 1), createIDs('cookies', 1),
deviceToken ? clearDeviceToken(deviceToken) : undefined, deviceToken ? clearDeviceToken(deviceToken) : undefined,
]); ]);
const cookieRow = [ const cookieRow = [
cookieID, cookieID,
cookieHash, cookieHash,
userID, userID,
platform, platform,
time, time,
time, time,
deviceToken, deviceToken,
versionsString, versionsString,
primaryIdentityPublicKey,
]; ];
const query = SQL` const query = SQL`
INSERT INTO cookies(id, hash, user, platform, creation_time, last_used, INSERT INTO cookies(id, hash, user, platform, creation_time, last_used,
device_token, versions) device_token, versions, public_key)
VALUES ${[cookieRow]} VALUES ${[cookieRow]}
`; `;
await dbQuery(query); await dbQuery(query);
return { return {
loggedIn: true, loggedIn: true,
id: userID, id: userID,
platformDetails, platformDetails,
deviceToken, deviceToken,
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines