Paths

Table of Contentst

[services][backup] SendLog 1/4 - create handler module
ClosedPublic
Actions

Authored by bartek on Jan 10 2023, 4:33 PM.

Details

Reviewers

varun
tomek
• jon
• max
michal

Commits

rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module

Summary

Created module for SendLog endpoint and added its its invocation in the grpc handler.

Depends on D6207

Test Plan

Service builds and starts. This code has no logic yet.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 10 2023, 4:33 PM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 10 2023, 4:33 PM

bartek added a child revision: D6212: [services][backup] SendLog 2/4 - handle non-data inputs.Jan 10 2023, 4:37 PM

Harbormaster completed remote builds in B15222: Diff 20752.Jan 10 2023, 4:48 PM

bartek added a reviewer: michal.Jan 11 2023, 6:39 PM

bartek published this revision for review.Jan 11 2023, 9:30 PM

tomek accepted this revision.Jan 12 2023, 3:05 PM

tomek added inline comments.

services/backup/src/service/mod.rs
122–123 ↗	(On Diff #20752)	Do we have to clone database client?

This revision is now accepted and ready to land.Jan 12 2023, 3:05 PM

bartek added inline comments.Jan 12 2023, 3:12 PM

services/backup/src/service/mod.rs
122–123 ↗	(On Diff #20752)	Good catch, a leftover from my previous implementation, where this code was unnecessarily run in a separate task

Removed user_id field from logs
Removed unnecessary clone

Harbormaster completed remote builds in B15313: Diff 20888.Jan 12 2023, 6:24 PM

Rebase

Harbormaster completed remote builds in B15468: Diff 21090.Jan 19 2023, 5:55 PM

Closed by commit rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module. · Explain WhyJan 19 2023, 6:08 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4d3018f17336: [services][backup] SendLog 1/4 - create handler module.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

service/

handlers/

send_log.rs

80 lines

mod.rs

46 lines

Diff 21106

View Options

services/backup/src/service/handlers/send_log.rs