For the needs of the Rust service development, I moved the C++ implementation to the old dir.
- Modified Dockerfile accordingly
- Modified CMakeLists accordingly
- Left blob_client untouched as it is convenient for me to keep it where it is.
Details
Details
- Docker container builds
- Service integration tests are passing
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/Dockerfile | ||
|---|---|---|
| 26 ↗ | (On Diff #19246) | would like to avoid adding conditional cmake logic around our particular usage of docker, and would prefer the docker context to reflect the shape of the repository. or you could do COPY services/backup/old/ /transferred/services/backup/old |
| services/backup/Dockerfile | ||
|---|---|---|
| 26 ↗ | (On Diff #19246) | Yeah, me neither like this solution, however there are just two reasons I did this:
But I like your suggestion with COPY into the [...]/old dir in docker image, so I'll go with that. |
Comment Actions
Moved the blob_client to the old directory, reverted the CMake logic.
I decided to do this as it turned out I won't be re-using this code anyway.
Comment Actions
Yes, the blob_client Rust library is going to be deleted along with the C++ codebase in ENG-2403.