[services][backup] AddAttachments 3/4 - main handler logic
ClosedPublic
Actions

Authored by bartek on Jan 9 2023, 12:24 PM.

Details

Reviewers

varun
tomek
• jon
• max

Commits

rCOMM5e222d213d3f: [services][backup] AddAttachments 3/4 - main handler logic

Summary

Implemented the actual AddAttachments endpoint logic. In case of logs, it additionally checks if their size doesn't exceed the size limit. Moving their contents to blob service is implemented in the subsequent diff

Depends on D6205

Test Plan

The service can be started along with blob service and localstack and the AddAttachments endpoint can now be called for backups.
Testing logs requires adding LogItems manually to DB, as SendLog endpoint is unimplemented yet.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 9 2023, 12:24 PM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 9 2023, 12:24 PM

bartek added a child revision: D6207: [services][backup] AddAttachments 4/4 - moving to blob.Jan 9 2023, 12:29 PM

Harbormaster completed remote builds in B15213: Diff 20741.Jan 9 2023, 12:35 PM

bartek published this revision for review.Jan 9 2023, 12:36 PM

tomek accepted this revision.Jan 11 2023, 5:54 AM

tomek added inline comments.

services/backup/src/service/handlers/add_attachments.rs
65–73 ↗	(On Diff #20741)	Are we handling all the cases here? What if `log_item.persisted_in_blob` is true? Should we still call `db.put_log_item`?

This revision is now accepted and ready to land.Jan 11 2023, 5:54 AM

bartek added inline comments.Jan 11 2023, 2:01 PM

services/backup/src/service/handlers/add_attachments.rs
65–73 ↗	(On Diff #20741)	Yes, this code is correct. If the item is not already persisted and is small enough, we store it directly in db If it is already persisted, then `LogItem` representation is already correct and we can just save it to db. If it's not persisted, but became too large, the `move_to_blob` creates a `LogItem` database entity representing log stored in blob service. It is implemented in the next diff. Then we put the updated entity into the db.