Paths

Table of Contentst

Differential D5841

[services][backup] Move C++ impl to 'old' directory
ClosedPublic
Actions

Authored by bartek on Dec 8 2022, 4:03 AM.

Tags

None

Referenced Files

	F3286445: D5841.diff
	Sat, Nov 16, 1:23 PM

	Unknown Object (File)
	Sun, Nov 10, 10:05 PM

	Unknown Object (File)
	Sat, Nov 9, 3:20 PM

	Unknown Object (File)
	Sat, Nov 9, 2:19 PM

	Unknown Object (File)
	Sat, Nov 9, 12:22 PM

	Unknown Object (File)
	Thu, Nov 7, 5:47 AM

	Unknown Object (File)
	Mon, Nov 4, 4:00 PM

	Unknown Object (File)
	Mon, Nov 4, 4:00 PM

Subscribers

Details

Reviewers

tomek
varun
• jon

Commits

rCOMM97f2b69903cf: [services][backup] Move C++ impl to 'old' directory

Summary

For the needs of the Rust service development, I moved the C++ implementation to the old dir.

Modified Dockerfile accordingly
Modified CMakeLists accordingly
Left blob_client untouched as it is convenient for me to keep it where it is.

Test Plan

Docker container builds
Service integration tests are passing

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 8 2022, 4:03 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 8 2022, 4:03 AM

bartek added a child revision: D5842: [services][backup] Bootstrap new Rust project.Dec 8 2022, 4:08 AM

bartek published this revision for review.Dec 8 2022, 4:13 AM

bartek edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B14059: Diff 19246.Dec 8 2022, 4:15 AM

• jon requested changes to this revision.Dec 8 2022, 12:21 PM

• jon added inline comments.

services/backup/Dockerfile
26 ↗	(On Diff #19246)	would like to avoid adding conditional cmake logic around our particular usage of docker, and would prefer the docker context to reflect the shape of the repository. or you could do `COPY services/backup/old/ /transferred/services/backup/old`

This revision now requires changes to proceed.Dec 8 2022, 12:21 PM

bartek added inline comments.Dec 11 2022, 11:49 PM

services/backup/Dockerfile
26 ↗	(On Diff #19246)	Yeah, me neither like this solution, however there are just two reasons I did this: The same technique was used for blob service CMake (see snippet) before I ever touched it, so I just copy-pasted this solution This is temporary solution, this CMake is going to be removed anyway But I like your suggestion with `COPY` into the `[...]/old` dir in docker image, so I'll go with that.

Moved the blob_client to the old directory, reverted the CMake logic.

I decided to do this as it turned out I won't be re-using this code anyway.

Harbormaster completed remote builds in B15076: Diff 20567.Jan 4 2023, 5:15 AM

• jon accepted this revision.Jan 4 2023, 9:15 AM

This revision is now accepted and ready to land.Jan 4 2023, 9:15 AM

If we're not going to use it, should we just delete it?

In D5841#184931, @ashoat wrote:

If we're not going to use it, should we just delete it?

Yes, the blob_client Rust library is going to be deleted along with the C++ codebase in ENG-2403.

tomek accepted this revision.Jan 9 2023, 3:23 AM

Closed by commit rCOMM97f2b69903cf: [services][backup] Move C++ impl to 'old' directory (authored by bartek). · Explain WhyJan 11 2023, 1:30 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM97f2b69903cf: [services][backup] Move C++ impl to 'old' directory.

Revision Contents
Changeset List

Path

Size

2 lines

services/

backup/

2 lines

blob_client/

src/

	old/

136 lines

blob_client/

33 lines

10 lines

src/

2 lines

135 lines

55 lines

246 lines

src/

BackupServiceImpl.h

42 lines

BackupServiceImpl.cpp

63 lines

26 lines

DatabaseEntities/

81 lines

122 lines

70 lines

148 lines

DatabaseManager.h

42 lines

DatabaseManager.cpp

173 lines

Reactors/

server/

AddAttachmentsUtility.h

25 lines

AddAttachmentsUtility.cpp

102 lines

CreateNewBackupReactor.h

52 lines

CreateNewBackupReactor.cpp

124 lines

PullBackupReactor.h

66 lines

PullBackupReactor.cpp

216 lines

RecoverBackupKeyReactor.h

33 lines

SendLogReactor.h

61 lines

SendLogReactor.cpp

178 lines

26 lines

71 lines

42 lines

test/

20 lines

DatabaseManagerTest.cpp

132 lines

src/

BackupServiceImpl.h

BackupServiceImpl.cpp

DatabaseEntities/

DatabaseManager.h

DatabaseManager.cpp

Reactors/

server/

AddAttachmentsUtility.h

AddAttachmentsUtility.cpp

CreateNewBackupReactor.h

CreateNewBackupReactor.cpp

PullBackupReactor.h

PullBackupReactor.cpp

RecoverBackupKeyReactor.h

SendLogReactor.h

SendLogReactor.cpp

test/

DatabaseManagerTest.cpp

Diff 20567

.gitignore

Loading...

services/backup/CMakeLists.txt

Loading...

services/backup/Dockerfile

Loading...

services/backup/blob_client/Cargo.lock

Loading...

services/backup/blob_client/Cargo.toml

Loading...

services/backup/blob_client/build.rs

Loading...

services/backup/blob_client/src/constants.rs

Loading...

services/backup/blob_client/src/get_client.rs

Loading...

services/backup/blob_client/src/lib.rs

Loading...

services/backup/blob_client/src/put_client.rs

Loading...

services/backup/old/CMakeLists.txt

Loading...

services/backup/old/blob_client/Cargo.lock

Loading...

services/backup/old/blob_client/Cargo.toml

Loading...

services/backup/old/blob_client/build.rs

Loading...

services/backup/old/blob_client/src/constants.rs

Loading...

services/backup/old/blob_client/src/get_client.rs

Loading...

services/backup/old/blob_client/src/lib.rs

Loading...

services/backup/old/blob_client/src/put_client.rs

Loading...

services/backup/old/src/BackupServiceImpl.h

Loading...

services/backup/old/src/BackupServiceImpl.cpp

Loading...

services/backup/old/src/Constants.h

Loading...

services/backup/old/src/DatabaseEntities/BackupItem.h

Loading...

services/backup/old/src/DatabaseEntities/BackupItem.cpp

Loading...

services/backup/old/src/DatabaseEntities/LogItem.h

Loading...

services/backup/old/src/DatabaseEntities/LogItem.cpp

Loading...

services/backup/old/src/DatabaseManager.h

Loading...

services/backup/old/src/DatabaseManager.cpp

Loading...

services/backup/old/src/Reactors/server/AddAttachmentsUtility.h

Loading...

services/backup/old/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...

services/backup/old/src/Reactors/server/CreateNewBackupReactor.h

Loading...

services/backup/old/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...

services/backup/old/src/Reactors/server/PullBackupReactor.h

Loading...

services/backup/old/src/Reactors/server/PullBackupReactor.cpp

Loading...

services/backup/old/src/Reactors/server/RecoverBackupKeyReactor.h

Loading...

services/backup/old/src/Reactors/server/SendLogReactor.h

Loading...

services/backup/old/src/Reactors/server/SendLogReactor.cpp

Loading...

services/backup/old/src/Tools.h

Loading...

services/backup/old/src/Tools.cpp

Loading...

services/backup/old/src/server.cpp

Loading...

services/backup/old/test/BackupTest.cpp

Loading...

services/backup/old/test/DatabaseManagerTest.cpp

Loading...

services/backup/src/BackupServiceImpl.h

Loading...

services/backup/src/BackupServiceImpl.cpp

Loading...

services/backup/src/Constants.h

Loading...

services/backup/src/DatabaseEntities/BackupItem.h

Loading...

services/backup/src/DatabaseEntities/BackupItem.cpp

Loading...

services/backup/src/DatabaseEntities/LogItem.h

Loading...

services/backup/src/DatabaseEntities/LogItem.cpp

Loading...

services/backup/src/DatabaseManager.h

Loading...

services/backup/src/DatabaseManager.cpp

Loading...

services/backup/src/Reactors/server/AddAttachmentsUtility.h

Loading...

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.h

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/PullBackupReactor.h

Loading...

services/backup/src/Reactors/server/PullBackupReactor.cpp

Loading...

services/backup/src/Reactors/server/RecoverBackupKeyReactor.h

Loading...

services/backup/src/Reactors/server/SendLogReactor.h

Loading...

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...

services/backup/src/Tools.h

Loading...

services/backup/src/Tools.cpp

Loading...

services/backup/src/server.cpp

Loading...

services/backup/test/BackupTest.cpp

Loading...

services/backup/test/DatabaseManagerTest.cpp

Loading...