[services][backup] Scaffold gRPC server
ClosedPublic
Actions

Authored by bartek on Dec 8 2022, 4:11 AM.

Details

Reviewers

varun
tomek
• jon

Commits

rCOMM174fffba3a18: [services][backup] Scaffold gRPC server

Summary

Created gRPC handlers, added logging and server init code. Some copy-paste from blob service.

Depends on D5842

Test Plan

Service should respond with UNIMPLEMENTED to gRPC calls.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 8 2022, 4:11 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 8 2022, 4:11 AM

bartek published this revision for review.Dec 8 2022, 4:16 AM

Harbormaster completed remote builds in B14061: Diff 19248.Dec 8 2022, 4:23 AM

Can you explain what EnvFilters are and why we're using them here?

This revision is now accepted and ready to land.Dec 9 2022, 9:13 AM

Rebase
Slightly cleaned up mod/use structure

In D5843#174783, @varun wrote:

Can you explain what EnvFilters are and why we're using them here?

I explained them more in-depth in the description of this diff: https://phab.comm.dev/D5729 - the same code is already used in blob service
Basically, it allows you to use the RUST_LOG env var (default, configurable in constants.rs) to select displayed log level: trace/debug/info/warn/error.

Harbormaster completed remote builds in B15079: Diff 20570.Jan 4 2023, 5:51 AM

bartek added a child revision: D6161: [services][backup] Introduce cmdline args config.Jan 4 2023, 6:16 AM

Fix typo (blob_service -> backup_service variable name)

Harbormaster completed remote builds in B15108: Diff 20603.Jan 5 2023, 3:53 AM

tomek accepted this revision.Jan 9 2023, 3:44 AM

Closed by commit rCOMM174fffba3a18: [services][backup] Scaffold gRPC server (authored by bartek). · Explain WhyJan 11 2023, 1:30 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM174fffba3a18: [services][backup] Scaffold gRPC server.