HomePhabricator
Diffusion Comm 9fcb517e86f4

[web] render user avatars in chat screen

Description

[web] render user avatars in chat screen

Summary:
Rendered the user avatars in the chat screen. An important thing to note about this diff vs D7067 is that since web has a lot more screen real estate than native, I DID NOT reduce the width of chat bubbles. I thought about it at first; however, after seeing how the chat screen looked visually with the avatar, I felt that it was unnecessary to reduce the width of the chat bubbles as we did in native

Depends on D7194

Test Plan:
Please look at the screenshots below to see the changes I made (only handles the user avatars in the chat screen and none of the thread avatars shown in the UI--- those will come later in the stack)

Before:

Screenshot 2023-03-27 at 5.42.09 PM.png (2×3 px, 927 KB)

After:

Screenshot 2023-03-27 at 5.41.51 PM.png (2×3 px, 991 KB)

Under the hood:

Before:

Screenshot 2023-03-27 at 4.50.44 PM.png (1×3 px, 1 MB)

After:

Screenshot 2023-03-27 at 4.52.56 PM.png (2×3 px, 1 MB)

Responsiveness:

Before:

After:

Responsiveness with super thin photos:

Before:

After:

Reviewers: ashoat, atul

Reviewed By: ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7195

Details

Provenance
ginsuAuthored on Mar 26 2023, 8:58 PM
Reviewer
ashoat
Differential Revision
D7195: [web] render user avatars in chat screen
Parents
rCOMMb6d5c0dde0e3: [web] render user avatar in account screen
Branches
Unknown
Tags
Unknown