Page MenuHomePhabricator

[web] render user avatars in chat screen
ClosedPublic

Authored by ginsu on Mar 27 2023, 7:07 AM.
Tags
None
Referenced Files
F1590954: D7195.diff
Fri, Apr 19, 10:44 AM
Unknown Object (File)
Mar 7 2024, 4:03 AM
Unknown Object (File)
Mar 7 2024, 4:03 AM
Unknown Object (File)
Mar 7 2024, 4:03 AM
Unknown Object (File)
Feb 26 2024, 5:56 PM
Unknown Object (File)
Feb 12 2024, 3:58 AM
Unknown Object (File)
Feb 12 2024, 3:58 AM
Unknown Object (File)
Feb 12 2024, 3:57 AM
Subscribers

Details

Summary

Rendered the user avatars in the chat screen. An important thing to note about this diff vs D7067 is that since web has a lot more screen real estate than native, I DID NOT reduce the width of chat bubbles. I thought about it at first; however, after seeing how the chat screen looked visually with the avatar, I felt that it was unnecessary to reduce the width of the chat bubbles as we did in native

Depends on D7194

Test Plan

Please look at the screenshots below to see the changes I made (only handles the user avatars in the chat screen and none of the thread avatars shown in the UI--- those will come later in the stack)

Before:

Screenshot 2023-03-27 at 5.42.09 PM.png (2×3 px, 927 KB)

After:

Screenshot 2023-03-27 at 5.41.51 PM.png (2×3 px, 991 KB)

Under the hood:

Before:

Screenshot 2023-03-27 at 4.50.44 PM.png (1×3 px, 1 MB)

After:

Screenshot 2023-03-27 at 4.52.56 PM.png (2×3 px, 1 MB)

Responsiveness:

Before:

After:

Responsiveness with super thin photos:

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Mar 27 2023, 7:22 AM
This revision is now accepted and ready to land.Mar 27 2023, 4:29 PM
web/chat/composed-message.react.js
144 ↗(On Diff #24198)

Hmm it seems like we'll need to refactor this after getAvatarForUser gets converted to a hook (see my chat message)

ginsu edited the test plan for this revision. (Show Details)

replace Avatar with UserAvatar

This revision was automatically updated to reflect the committed changes.