[web] render thread avatars in thread subchannel/sidebar modals
ClosedPublic
Actions

Authored by ginsu on Apr 3 2023, 1:56 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMMf5c0d2f0f8b7: [web] render thread avatars in thread subchannel/sidebar modals

Summary

Rendered thread avatars in thread subchannel/thread sidebars modals. There were no official designs for these; however, I synced with ted about this last week and he gave me his stamp of approval

Depends on D7210

Test Plan

Please view the screenshots below to see the changes I made:

Subchannels:

Before:

Screenshot 2023-04-03 at 4.58.35 AM.png (2×3 px, 858 KB)

After:

Screenshot 2023-04-03 at 4.59.12 AM.png (2×3 px, 936 KB)

Subthreads:

Before:

Screenshot 2023-04-03 at 4.58.39 AM.png (2×3 px, 828 KB)

After:

Screenshot 2023-04-03 at 4.59.16 AM.png (2×3 px, 870 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 3 2023, 1:56 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 3 2023, 1:56 AM

ginsu edited the test plan for this revision. (Show Details)Apr 3 2023, 2:00 AM

ginsu added reviewers: ashoat, atul.

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7210: [web] render thread avatars on chat screen.

ginsu attached a referenced file: F459802: Screenshot 2023-04-03 at 4.59.16 AM.png. (Show Details)

ginsu attached a referenced file: F459801: Screenshot 2023-04-03 at 4.58.39 AM.png. (Show Details)

ginsu attached a referenced file: F459800: Screenshot 2023-04-03 at 4.59.12 AM.png. (Show Details)

ginsu attached a referenced file: F459799: Screenshot 2023-04-03 at 4.58.35 AM.png. (Show Details)

ginsu added a child revision: D7276: [web] render thread avatars in thread picker modal.Apr 3 2023, 2:03 AM

Harbormaster completed remote builds in B17917: Diff 24547.Apr 3 2023, 2:10 AM

ginsu requested review of this revision.Apr 3 2023, 2:10 AM

Looks good. I think the layout of those modals is generally weird (particularly the vertical spacing), but this is a strict improvement.

web/modals/threads/sidebars/sidebar.react.js
45–48 ↗	(On Diff #24547)	You could also do something more concise eg classNames(css.longTextEllipsis, css.avatarOffset) but I actually prefer what you did since it's more consistent.