Page MenuHomePhabricator
Differential D7205

[web] render user avatars in account relationship lists
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 8:18 AM
Unknown Object (File)
Thu, Mar 28, 8:18 AM
Unknown Object (File)
Thu, Mar 28, 8:18 AM
Unknown Object (File)
Thu, Mar 28, 8:18 AM
Unknown Object (File)
Thu, Mar 28, 8:17 AM
Unknown Object (File)
Thu, Mar 28, 8:13 AM
Unknown Object (File)
Mar 5 2024, 11:54 PM
Unknown Object (File)
Mar 5 2024, 11:54 PM
View All 46 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMa0a81029166c: [web] render user avatars in account relationship lists
Summary

render user avatars in account relationship lists. This includes the friends list and the block list

This diff won't be landed until avatars is given the green light to be released

Depends on D7196

Test Plan

Please see the screenshots below to see the changes I made:

Before:

Friends List:

Screenshot 2023-03-27 at 6.47.58 PM.png (2×3 px, 721 KB)

Block List:

Screenshot 2023-03-27 at 6.48.02 PM.png (2×3 px, 720 KB)

After:

Friends List:

Screenshot 2023-03-27 at 6.49.02 PM.png (2×3 px, 705 KB)

Block List:

Screenshot 2023-03-27 at 6.49.05 PM.png (2×3 px, 704 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 27 2023, 3:49 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 3:49 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 3:53 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu added a parent revision: D7196: [web] render user avatars in message reactions modal.
ginsu attached a referenced file: F448490: Screenshot 2023-03-27 at 6.49.05 PM.png. (Show Details)
ginsu attached a referenced file: F448489: Screenshot 2023-03-27 at 6.49.02 PM.png. (Show Details)
ginsu attached a referenced file: F448488: Screenshot 2023-03-27 at 6.48.02 PM.png. (Show Details)
ginsu attached a referenced file: F448487: Screenshot 2023-03-27 at 6.47.58 PM.png. (Show Details)
ginsu added a child revision: D7206: [web] render user avatars in chat thread composer.Mar 27 2023, 4:01 PM
Harbormaster completed remote builds in B17711: Diff 24244.Mar 27 2023, 4:05 PM
ginsu requested review of this revision.Mar 27 2023, 4:05 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:17 PM
ashoat added inline comments.Mar 27 2023, 4:42 PM
web/settings/relationship/block-list-row.react.js
20 ↗(On Diff #24244)

Don't think this useMemo is currently necessary... does getAvatarForUser ever create a new object?

atul accepted this revision.Mar 28 2023, 1:20 PM

(Please address @ashoat's feedback before landing)

This revision is now accepted and ready to land.Mar 28 2023, 1:20 PM
ginsu updated this revision to Diff 24540.Apr 3 2023, 1:32 AM

replace Avatar with UserAvatar

Harbormaster completed remote builds in B17910: Diff 24540.Apr 3 2023, 1:47 AM
ginsu updated this revision to Diff 24607.Apr 4 2023, 11:04 AM

rebase before landing

Harbormaster completed remote builds in B17970: Diff 24607.Apr 4 2023, 11:21 AM
Closed by commit rCOMMa0a81029166c: [web] render user avatars in account relationship lists (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa0a81029166c: [web] render user avatars in account relationship lists.

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
6 lines
6 lines
7 lines

Diff 24626

View Options

web/settings/relationship/block-list-row.react.js

Loading...
View Options

web/settings/relationship/friend-list-row.react.js

Loading...
View Options

web/settings/relationship/user-list-row.css

Loading...