Paths

Table of Contentst

Differential D7208

[web] render user avatars in typeahead tooltip
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 4:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 13, 6:00 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:51 AM

	Unknown Object (File)
	Mar 5 2024, 11:56 PM

View All 73 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM87476b26da82: [web] render user avatars in typeahead tooltip

Summary

render user avatars in typeahead tooltip

This diff won't be landed until avatars is given the green light to be released

Depends on D7207

Test Plan

Please view the screenshots to see the changes I made:

Before:

Screenshot 2023-03-27 at 7.02.31 PM.png (2×3 px, 864 KB)

After:

Screenshot 2023-03-27 at 7.02.50 PM.png (2×3 px, 876 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 27 2023, 4:09 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 4:10 PM

ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:11 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7207: [web] render user avatars in thread memebers modal.

ginsu attached a referenced file: F448588: Screenshot 2023-03-27 at 7.02.50 PM.png. (Show Details)

ginsu attached a referenced file: F448587: Screenshot 2023-03-27 at 7.02.31 PM.png. (Show Details)

ginsu added a child revision: D7209: [web] render thread avatars in the community drawer.Mar 27 2023, 4:19 PM

Harbormaster completed remote builds in B17714: Diff 24247.Mar 27 2023, 4:24 PM

ginsu requested review of this revision.Mar 27 2023, 4:24 PM

ashoat added inline comments.Mar 27 2023, 4:44 PM

web/utils/typeahead-utils.js
149 ↗	(On Diff #24247)	This looks like a case where we would want to determine ENS avatars "downstream" of where `getAvatarForUser` is called. We can't use a hook in `getTypeaheadTooltipActions`, but we can use a hook here

(Please address @ashoat's feedback before landing)

atul accepted this revision.Mar 28 2023, 1:33 PM

This revision is now accepted and ready to land.Mar 28 2023, 1:33 PM

replace Avatar with UserAvatar

Harbormaster completed remote builds in B17914: Diff 24544.Apr 3 2023, 2:03 AM

rebase before landing

Harbormaster completed remote builds in B17973: Diff 24610.Apr 4 2023, 11:30 AM

Closed by commit rCOMM87476b26da82: [web] render user avatars in typeahead tooltip (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM87476b26da82: [web] render user avatars in typeahead tooltip.

Revision Contents
Changeset List

Path

Size

web/

chat/

typeahead-tooltip.css

4 lines

utils/

typeahead-utils.js

11 lines

Diff 24627

web/chat/typeahead-tooltip.css

Loading...

web/utils/typeahead-utils.js

Loading...