Paths

Table of Contentst

Differential D7207

[web] render user avatars in thread memebers modal
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 4:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:58 AM

	Unknown Object (File)
	Thu, Mar 28, 7:51 AM

	Unknown Object (File)
	Mar 5 2024, 11:54 PM

	Unknown Object (File)
	Mar 5 2024, 11:54 PM

View All 53 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM57643deb4cc9: [web] render user avatars in thread memebers modal

Summary

render user avatars in thread memebers modal. This includes the members modal and the add members modal

This diff won't be landed until avatars is given the green light to be released

Depends on D7206

Test Plan

Please view the screenshots below to see the changes I made:

Before:

Members Modal:

Screenshot 2023-03-27 at 7.03.37 PM.png (2×3 px, 799 KB)

Add members modal:

Screenshot 2023-03-27 at 7.03.39 PM.png (2×3 px, 741 KB)

After:

Members modal:

Screenshot 2023-03-27 at 7.03.50 PM.png (2×3 px, 818 KB)

Add members modal:

Screenshot 2023-03-27 at 7.03.52 PM.png (2×3 px, 763 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 27 2023, 4:04 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 4:04 PM

ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:08 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7206: [web] render user avatars in chat thread composer.

ginsu attached a referenced file: F448556: Screenshot 2023-03-27 at 7.03.52 PM.png. (Show Details)

ginsu attached a referenced file: F448555: Screenshot 2023-03-27 at 7.03.50 PM.png. (Show Details)

ginsu attached a referenced file: F448554: Screenshot 2023-03-27 at 7.03.39 PM.png. (Show Details)

ginsu attached a referenced file: F448553: Screenshot 2023-03-27 at 7.03.37 PM.png. (Show Details)

ginsu added a child revision: D7208: [web] render user avatars in typeahead tooltip.Mar 27 2023, 4:11 PM

ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:16 PM

Harbormaster completed remote builds in B17713: Diff 24246.Mar 27 2023, 4:20 PM

ginsu requested review of this revision.Mar 27 2023, 4:20 PM

ashoat added inline comments.Mar 27 2023, 4:42 PM

web/modals/components/add-members-item.react.js
41–44 ↗	(On Diff #24246)	Don't think this `useMemo` is currently necessary... does `getAvatarForUser` ever create a new object?
web/modals/threads/members/member.react.js
146–149 ↗	(On Diff #24246)	Don't think this `useMemo` is currently necessary... does `getAvatarForUser` ever create a new object?

(Please address @ashoat's feedback before landing)

This revision is now accepted and ready to land.Mar 28 2023, 1:21 PM

replace Avatar with UserAvatar

Harbormaster completed remote builds in B17913: Diff 24543.Apr 3 2023, 2:00 AM

rebase before landing

Harbormaster completed remote builds in B17972: Diff 24609.Apr 4 2023, 11:26 AM

Closed by commit rCOMM57643deb4cc9: [web] render user avatars in thread memebers modal (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM57643deb4cc9: [web] render user avatars in thread memebers modal.

Revision Contents
Changeset List

Path

Size

web/

modals/

components/

add-members-item.react.js

6 lines

add-members.css

11 lines

threads/

members/

member.react.js

5 lines

Diff 24625

web/modals/components/add-members-item.react.js

Loading...

web/modals/components/add-members.css

Loading...

web/modals/threads/members/member.react.js

Loading...