HomePhabricator
Diffusion Comm a962807ac47f

[lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`

Description

[lib] Add skipMemberAdminRoleCheck argument to threadIsWithBlockedUserOnly

Summary:
We want this specifically for useThreadsWithPermission where we're doing member admin role check the "updated way." We handle the early return condition previously handled by threadOrParentThreadHasAdminRole using community root role check.

Considered a few other options which included

  • turning threadIsWithBlockedUserOnly into hook (would be tedious because we'd need to "hook-ify" a couple other functions and then have variants which accept collection of items vs. single item because hooks can't be called in loop, etc.)
  • creating duplicate/higher order functions similar to threadFrozenDueToBlock/threadFrozenDueToViewerBlock but the call stack would get more complex than needed imo

Depends on D12150

Test Plan: Will add log statements to make sure behavior is as expected. Specifically with native client connected to prod store since after MariaDB update my local DB is sparse.

Reviewers: ashoat, ginsu, tomek, varun

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D12154

Details

Provenance
atulAuthored on May 31 2024, 11:30 AM
Reviewer
ashoat
Differential Revision
D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`
Parents
rCOMM41dd2ebdbe6f: [lib] Ignore exceptions in extractUserIDsFromPayload
Branches
Unknown
Tags
Unknown