HomePhabricator
Diffusion Comm adeee6010336

[lib] introduce stringForReactionList in reaction-utils

Description

[lib] introduce stringForReactionList in reaction-utils

Summary:
introduce stringForReactionList in reaction-utils. This is a refactor where D5813 and D5814 were using the same logic in web and native, so we should put that logic into a helper function in lib. We then can call the function from web and native and get the same results


Depends on D5812
Linear Task: ENG-2247

Test Plan:
Please to look at the screenshots to see that the reactions are still being rendered correctly

Native:

One reaction:

Screenshot 2022-12-15 at 6.38.32 PM.png (1×1 px, 796 KB)

Multiple reactions:

Screenshot 2022-12-15 at 6.38.25 PM.png (1×1 px, 797 KB)

Web:

One reaction:

Screenshot 2022-12-15 at 6.39.02 PM.png (2×3 px, 1 MB)

Multiple reactions:

Screenshot 2022-12-15 at 6.39.09 PM.png (2×3 px, 1 MB)

Reviewers: atul, tomek, rohan

Reviewed By: atul, rohan

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D5878

Details

Provenance
ginsuAuthored on Dec 15 2022, 3:02 PM
Reviewer
atul
Differential Revision
D5878: [lib] introduce stringForReactionList in reaction-utils
Parents
rCOMM3e1cc43ba3b1: [native] introduced reactions to chat item height measurer
Branches
Unknown
Tags
Unknown