HomePhabricator
Diffusion Comm c05d8f18fefe

[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`

Description

[lib] Update roleIsAdminRole to consider roleInfo?.specialRole

Summary:
Update the roleIsAdminRole utility to consider roleInfo?.specialRole field when handling clients where specialRole has been populated.

Note that this branch will be skipped because specialRole field is not yet set on clients.

Test Plan:

  1. Hard code includeSpecialRoleFieldInRoles to true
  2. Check to see that specialRole field of roles are populated in ThreadStore
  3. Set a breakpoint and see that the branch is hit and function behaves as expected.

Reviewers: ginsu, tomek, kamil, michal

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11148

Details

Provenance
atulAuthored on Feb 22 2024, 7:45 PM
Reviewer
tomek
Differential Revision
D11148: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
Parents
rCOMM1d74ee4f6ed5: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism
Branches
Unknown
Tags
Unknown