Page MenuHomePhabricator
Differential D11148

[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
ClosedPublic
Actions

Authored by atul on Feb 22 2024, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 3:44 AM
Unknown Object (File)
Wed, Jun 12, 7:35 PM
Unknown Object (File)
Fri, Jun 7, 10:15 PM
Unknown Object (File)
Fri, Jun 7, 6:55 PM
Unknown Object (File)
May 24 2024, 6:11 PM
Unknown Object (File)
May 21 2024, 4:46 AM
Unknown Object (File)
May 16 2024, 6:04 AM
Unknown Object (File)
May 4 2024, 10:31 AM
View All 25 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
kamil
michal
Commits
rCOMMc05d8f18fefe: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
Summary

Update the roleIsAdminRole utility to consider roleInfo?.specialRole field when handling clients where specialRole has been populated.

Note that this branch will be skipped because specialRole field is not yet set on clients.

Test Plan
  1. Hard code includeSpecialRoleFieldInRoles to true
  2. Check to see that specialRole field of roles are populated in ThreadStore
  3. Set a breakpoint and see that the branch is hit and function behaves as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
3 lines

Diff 37658

View Options

lib/shared/thread-utils.js

Loading...