Page MenuHomePhabricator

[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
ClosedPublic

Authored by atul on Feb 22 2024, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 5:46 PM
Unknown Object (File)
Sat, Nov 16, 5:46 PM
Unknown Object (File)
Sat, Nov 16, 5:45 PM
Unknown Object (File)
Sat, Nov 16, 5:44 PM
Unknown Object (File)
Wed, Nov 13, 2:59 PM
Unknown Object (File)
Tue, Nov 12, 1:48 PM
Unknown Object (File)
Oct 14 2024, 7:04 PM
Unknown Object (File)
Oct 14 2024, 7:04 PM
Subscribers

Details

Summary

Update the roleIsAdminRole utility to consider roleInfo?.specialRole field when handling clients where specialRole has been populated.

Note that this branch will be skipped because specialRole field is not yet set on clients.

Test Plan
  1. Hard code includeSpecialRoleFieldInRoles to true
  2. Check to see that specialRole field of roles are populated in ThreadStore
  3. Set a breakpoint and see that the branch is hit and function behaves as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable