[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`
ClosedPublic
Actions

Authored by atul on Feb 22 2024, 7:57 PM.

Details

Reviewers

ginsu
tomek
kamil
michal

Commits

rCOMMc05d8f18fefe: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`

Summary

Update the roleIsAdminRole utility to consider roleInfo?.specialRole field when handling clients where specialRole has been populated.

Note that this branch will be skipped because specialRole field is not yet set on clients.

Test Plan

Hard code includeSpecialRoleFieldInRoles to true
Check to see that specialRole field of roles are populated in ThreadStore
Set a breakpoint and see that the branch is hit and function behaves as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 22 2024, 7:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 22 2024, 7:57 PM

atul added a child revision: D11149: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.Feb 22 2024, 7:59 PM

Harbormaster completed remote builds in B27080: Diff 37463.Feb 22 2024, 8:13 PM

atul requested review of this revision.Feb 22 2024, 8:13 PM

tomek accepted this revision.Feb 27 2024, 12:44 AM

This revision is now accepted and ready to land.Feb 27 2024, 12:44 AM

Closed by commit rCOMMc05d8f18fefe: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole` (authored by atul). · Explain WhyFeb 27 2024, 9:55 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc05d8f18fefe: [lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

3 lines

Diff 37463

View Options

lib/shared/thread-utils.js

[lib] Update `roleIsAdminRole` to consider `roleInfo?.specialRole`ClosedPublicActions