[lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`
ClosedPublic
Actions

Authored by atul on Feb 22 2024, 7:59 PM.

Details

Reviewers

ginsu
tomek
michal
kamil

Commits

rCOMM97d75c7931c6: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`

Summary

Similar to D11148, but for specialRoles.DEFAULT_ROLE.

Depends on D11148

Test Plan

Hard code includeSpecialRoleFieldInRoles to true
Check to see that specialRole field of roles are populated in ThreadStore
Set a breakpoint and see that the branch is hit and function behaves as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 22 2024, 7:59 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 22 2024, 7:59 PM

Harbormaster completed remote builds in B27081: Diff 37464.Feb 22 2024, 8:14 PM

atul requested review of this revision.Feb 22 2024, 8:14 PM

tomek accepted this revision.Feb 27 2024, 12:45 AM

This revision is now accepted and ready to land.Feb 27 2024, 12:45 AM

rebase and land

Harbormaster failed remote builds in B27208: Diff 37657!Feb 27 2024, 9:46 AM

This revision was landed with ongoing or failed builds.Feb 27 2024, 9:55 AM

Closed by commit rCOMM97d75c7931c6: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM97d75c7931c6: [lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`.

Harbormaster completed remote builds in B27208: Diff 37657.Feb 27 2024, 10:07 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

3 lines

Diff 37659

View Options

lib/shared/thread-utils.js

[lib] Update `roleIsDefaultRole` to consider `roleInfo?.specialRole`ClosedPublicActions