HomePhabricator
Diffusion Comm c07ce55fa912

[web] Push `onChange[Name/Description/Color]` callbacks down to…

Description

[web] Push onChange[Name/Description/Color] callbacks down to ThreadSettingsGeneralTab component

Summary:
Push onChange[Name/Description/Color] callbacks down to the ThreadSettingsGeneralTab component to clean up parent ThreadSettingsModal component and move them closer to where they're used.

  • Added threadInfo, queuedChanges, and setQueuedChanges props to ThreadSettingsGeneralTab component so callbacks could be "constructed" from the "child" component
  • Adding those props also lets us determine threadDescriptionValue, etc within child component instead of having to pass in from parent

Depends on D3826

Test Plan:

  1. Open ThreadSettingsModal
  2. Make sure that the "General" tab continues to look/work as expected

Reviewers: def-au1t, palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, Adrian, karol-bisztyga, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3827