HomePhabricator
Diffusion Comm c1ec9c0a5ec7

[native] change outerRingSelectedColor prop type from string to ViewStyle

Description

[native] change outerRingSelectedColor prop type from string to ViewStyle

Summary:
Based on a comment I got on D7323 it would be better to have the outerRingSelectedColor prop type be a ViewStyle so that we can use a color entry from color.js instead of picking a color in the EmojiAvatarCreation component, which will help maintain a consistent design system

Depends on D7353

Test Plan:
Tested the selected color outer ring in ColorSelectors and EmojiAvatarCreation and got the following in light and dark mode:

ColorSelectors (does not use the outerRingSelectedColor prop):

Dark:

Screenshot 2023-04-10 at 2.37.54 PM.png (1×1 px, 808 KB)

Light:

Screenshot 2023-04-10 at 2.37.39 PM.png (1×1 px, 814 KB)

EmojiAvatarCreation: (used modalSubtext entry from colors.js as the outerRingSelectedColor prop)

Dark:

Screenshot 2023-04-10 at 2.37.11 PM.png (1×1 px, 787 KB)

Light:

Screenshot 2023-04-10 at 2.37.24 PM.png (1×1 px, 796 KB)

Reviewers: ashoat, atul

Reviewed By: ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7373

Details

Provenance
ginsuAuthored on Apr 10 2023, 8:45 PM
Reviewer
ashoat
Differential Revision
D7373: [native] change outerRingSelectedColor prop type from string to ViewStyle
Parents
rCOMMc198c0e0f858: [native] changed name of loginText to whiteText
Branches
Unknown
Tags
Unknown