HomePhabricator
Diffusion Comm c4ef42a3fb4d

[native] Added show/hide password button.

Description

[native] Added show/hide password button.

Summary:
Linear issue: https://linear.app/comm/issue/ENG-2050/add-see-password-button-on-the-login-page-and-dont-clear-text-inputs
I've added show/hide password button on tight side of password input in login screen.
I've added new component PasswordInput wrapping regular TextInput.
In PasswordInput I used stateto keep track of button state.
Question:
Should we clear username and password after unsuccessful login?
If we have "show password" as an option I don't think it's necessary, but it's up to you.

Test Plan:
Built app.
Tested native app in simulators, both iOS and Android.

Reviewers: tomek, atul, marcin, kamil, ginsu

Reviewed By: tomek, kamil

Subscribers: abosh, kamil, marcin, atul, tomek, ashoat

Differential Revision: https://phab.comm.dev/D5489

Details

Provenance
przemekAuthored on Oct 27 2022, 1:33 AM
Reviewer
tomek
Differential Revision
D5489: [native] Added show/hide password button.
Parents
rCOMM1374f358843d: [web] Added show/hide password button.
Branches
Unknown
Tags
Unknown