HomePhabricator
Diffusion Comm c5489b0b75f3

[lib][native][web] Stop running ID schema migration on notifs

Description

[lib][native][web] Stop running ID schema migration on notifs

Summary:
This logic was initially added in D8460:

A notif can be sent after the app updates, but before migration is run or the keyserver is notified of the new codeVersion. In this case we need to handle notifications with older ids.

We no longer support versions of the app from before the ID schema migration, and as such these concerns are no longer relevant.

This diff resolves ENG-9806.

Test Plan:

  • I deployed a dev build to my physical iOS device
  • I logged in with a test user
  • I created a thick thread with another test user
  • I logged in as the other test user on a web device
  • I confirmed notifs were working for thick threads by sending a message to the thick thread from the web device
  • I applied this patch to prevent useHandleOlmMessageToDevice from working, such that messages would only appear if they are added to the store from a notif
  • I backgrounded the iOS app
  • I sent a message from the web device
  • I confirmed a notif was received
  • I foregrounded the iOS app and confirmed that the message appeared (before this diff, it did not)

Reviewers: tomek, kamil, angelika

Reviewed By: kamil

Differential Revision: https://phab.comm.dev/D13835

Details

Provenance
ashoatAuthored on Oct 30 2024, 2:27 PM
Reviewer
kamil
Differential Revision
D13835: [lib][native][web] Stop running ID schema migration on notifs
Parents
rCOMM13c7aded9674: [terraform] bump prod identity to 0.44
Branches
Unknown
Tags
Unknown