[lib][native][web] Stop running ID schema migration on notifs
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 30, 2:31 PM.

Details

Reviewers

tomek
kamil
angelika

Commits

rCOMMc5489b0b75f3: [lib][native][web] Stop running ID schema migration on notifs

Summary

This logic was initially added in D8460:

A notif can be sent after the app updates, but before migration is run or the keyserver is notified of the new codeVersion. In this case we need to handle notifications with older ids.

We no longer support versions of the app from before the ID schema migration, and as such these concerns are no longer relevant.

This diff resolves ENG-9806.

Test Plan

I deployed a dev build to my physical iOS device
I logged in with a test user
I created a thick thread with another test user
I logged in as the other test user on a web device
I confirmed notifs were working for thick threads by sending a message to the thick thread from the web device
I applied this patch to prevent useHandleOlmMessageToDevice from working, such that messages would only appear if they are added to the store from a notif
I backgrounded the iOS app
I sent a message from the web device
I confirmed a notif was received
I foregrounded the iOS app and confirmed that the message appeared (before this diff, it did not)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 30, 2:31 PM

ashoat added inline comments.Wed, Oct 30, 2:32 PM

native/push/android.js
55 ↗	(On Diff #45493)	If this approach is deemed too risky, something safer would be to gate the `convertRawMessageInfoToNewIDSchema` call in `convertNotificationMessageInfoToNewIDSchema` with `thickThreadIDRegex`, similar to how it's done here But I don't think this is really necessary