HomePhabricator
Diffusion Comm cb9e12f17a8c

[keyserver] Fix "added username and username" issue when adding user

Description

[keyserver] Fix "added username and username" issue when adding user

Summary:
I noticed that sometimes when I added somebody to a chat, their name would be printed twice in the robotext and the notif.

I investigated and found that it was because we're determining addedMemberIDs incorrectly in this code, as we're including any rows in the changeset for any threads. It's possible for adding somebody to a thread to cause their membership row to change for another thread, eg. a subthread they are already in.

To avoid this we could also check intent, but I figured checking threadID was more appropriate.

Test Plan: Confirmed that the "added username and username" probably went away in both robotext and notifs

Reviewers: tomek

Reviewed By: tomek

Subscribers: atul

Differential Revision: https://phab.comm.dev/D6616

Details

Provenance
ashoatAuthored on Feb 5 2023, 12:40 PM
Reviewer
tomek
Differential Revision
D6616: [keyserver] Fix "added username and username" issue when adding user
Parents
rCOMM43d39ba2bd35: [native] Cleanup of sidebar animation code
Branches
Unknown
Tags
Unknown